From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753582AbcJDIH1 (ORCPT ); Tue, 4 Oct 2016 04:07:27 -0400 Received: from mail-bl2nam02on0076.outbound.protection.outlook.com ([104.47.38.76]:8947 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753346AbcJDIHV (ORCPT ); Tue, 4 Oct 2016 04:07:21 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=fail action=none header.from=nxp.com; From: Madalin Bucur To: CC: , , , Subject: [net-next 09/13] fsl/fman: check of_get_phy_mode() return value Date: Tue, 4 Oct 2016 10:32:55 +0300 Message-ID: <1475566379-5078-10-git-send-email-madalin.bucur@nxp.com> X-Mailer: git-send-email 1.8.2.3 In-Reply-To: <1475566379-5078-1-git-send-email-madalin.bucur@nxp.com> References: <1475566379-5078-1-git-send-email-madalin.bucur@nxp.com> Reply-To: X-EOPAttributedMessage: 0 X-Matching-Connectors: 131200399988780621;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(86362001)(11100500001)(33646002)(8936002)(48376002)(53806999)(68736007)(50466002)(50986999)(76176999)(77096005)(50226002)(229853001)(5003940100001)(4326007)(2906002)(36756003)(69596002)(105606002)(586003)(2351001)(43066003)(2950100002)(19580395003)(5660300001)(305945005)(6666003)(4720700002)(106466001)(8676002)(87936001)(626004)(85426001)(189998001)(110136003)(81166006)(97736004)(47776003)(104016004)(3450700001)(6916009)(356003)(81156014)(7846002)(19580405001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR03MB2448;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11OLC004;1:DsY2cTLPhBQOtIoNZLj2c7O3b9D5eAwB7jawJF0XQlLUh0+OxezwCbGbHq8ucllOIWbwOjF0Mz4O6DeFeu9bYeotauPIbO7rrSMHU7KdjIAmb+Q+nIsDIUv6HeabnA0Y0s8UN9n1j0+CDiX/5ChFwnq0VdJUH/uI0UqMyfzsLEHLy5zkGCQLh+b+W8+dSMXwc02inj4shMMyppMmg1TppiS8FX2w7zpF+jbjH3mgzNWHstDFC90eUv7s+ae+zGsqjnv3JbwyX5YDYMlkq7g93uvE5jHYmX109QLumbCpfde2SH6xrupvMTPpncHTSoeCTmuj5mFddp94YAAjOL6YS7yYmf/QEXhxi8XW7SEjwWL0MPnYiGqn/j/O+IqZ52iZcAiCF1KErcjWbgLTIwbg4gBqOqFk2Z7m1r8nSj+5tjNewygM1CYdkA/+GdblwLCq9jVduvAmGAbcZKYOushBF0OpRGDvpVPsmGMhuKOiub+UUQq3AQW0YprGJTs7kb/XFtSu6dpvOrvoKw4ZwJ8Yh7DUEcRXsvV0O6UxCFcpjCPOWKg4nA+jLDW/lwZWSnPEUk7SglPJxHsSXLR8lvCNlWp9U+AJBktmOWHrXj2IiXylX4L3/CCXOoxGoxkUn5EC MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 449972dc-88c5-409b-6365-08d3ec28b61c X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2448;2:RmJBXxqFvzBwvnbdV40p6Mmu2XOVZRQ6nuyRlPnObB81xi+dK0bITWkpMLXiiIJGohnL22kSRrPqmd4YQNzpP9Rs1IVF4Zy18oQN6XVf9+61LOPJMGrbfw0+d7RTeQAiy6yEsorGsMf/eAoVRYjYhiLSnBE0PpHxUsNMBsd9jUlIn/i+fz5S1Jes7YrTzAAEba1ES9VsMq/JV0x0esZnAw==;3:1o04DdSsKy5FMaL/ar+twW5LERdppb7ndxQffj2F9TSOsoMEgJhUP4NIEIPVx9XaoA3oauJME+BL/qc1wKHPQV0F0ji8EIWeKt/WDaX9zNp7I3EyFwpQjc5bbW+o8ajm2eWphUTDZZOA6wm7cLNWvVY0o07sBrP141JNQ2mGh9aRa9Xy11KQwUzE/OBrqJ2f2H1jYV0OhJlThmcBUkb0s5IOebqbeo2IqgN1O0rKhHHlPFs/htP9NDbfZvR32ADm X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR03MB2448; X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2448;25:Tdj01SOB0lsN5Ekb4NRxeZAaGXtgM6qiZtylCAtFjNQ06ab5stFIpUGyyLVBBlO3pbadveMRp7nbNcvW4rfM1bMHyFQco/qoUEXjaVNbAyOdXtqR/yyt3bBH6NTPtmGQOYxjR/hMq8D9BbgE97k8Q8MWwvqnY2/pEWcS/eN5AdGRNC9uxCFVKxqRFanqDrIaTWxxpa7vytQWHUUZ9zUg4VzBF6kA268RY/0iDUh2tNeKq5qfBuDTg0+qTiTWMNhSbcMXcFTe6nJ9xpxtqA46W1N6Gg9D2JN7+dWJaLQTe5l7G7999uUHh1sscVQ/h/9QwbIjz6ZPgnhaRA+YeZxyF5LiCqfFLjMnaI6jnq1zohCMpPlkeEi29X4eNN9DyQxLxFWahl5IIU9/STVsVZUWR1bCDJ+VLW0EEnDuwwv4EjPdn13P29tU+ufgvvCI2QkA6TL9YfRyDeuoX0v2qjgqwa/8ZKC3dqdvJZn46hfL0MW2vRvH1hmtk4G2lOGNJ4eVI4UfaLfs1fiOD2P3+GCbK46oB2lF5mvO2aT/AiLol3lMesOcWyk4u6Gh1fL24KWYapCeF2bznN6/JFTsiObYU8pYG3oj18Hmf6RgZCEzIyiUA59j2ckHRhGc7I6FYlSQ4LxFMDiwIhH4rwLRaL1SLJWIQos5ngCr7VN0cneALtf4PQzNXimdBIm/a16QTZg8uMUTWYyH2CwgsQlhZLuKL13p3ylP4t2lIU0s4DL26c3/4EzpUlZUvPCfHqVoNejs X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2448;31:ARSgDFX4li+StWjCP/L2eWcERBwHlLOdSc1yONsCuk884GuMte8XyWSip4F0MvVNkLyU4BFjIIOYebB57gcdN0zNYHqsxaVlFH521xq9n5k3GqjvJEER7/tz6E82JUdjYINpG8JvbM58DJee7m13dVPrGapfHgg1p8Cerp4STTGwzM/QnmtwFJljZ/QHE3QZ3eo1m9svBHINhC7+6VWHKCtuud3p851UNBJe1lVKM2U1NSjBzsN9pPt+a8Pi2d3Alt2vQWFw2CgXCs9OHmyEXw==;4:/5uIjaVuazLUm9hiW5R1f7Go/JySvNihGhgyDHIdA8conh/BR/BOputtCAR7YzcGHs5FB7lLHMP4TuANut+TVkLxZKL6+Ss5I/vjlPt8llspFyO2gWTtSP5juEtRoke4z91TfQoktiCI6jmKKXcXc09t6GQko7J91GistNJ0hBtuDsvN/1Pi8yAqn8K1xsfy/mPalp8g9+4JudJDsS2uuBTALZnu1ea+y1uBlZJagMwfPAt/nHDwFeAQcdkpl2r13VhesJLgJ1kEA/E/OCiK1wRBMkoD2Tq50uM6o9Q/pG7X6ma49dV/1iKnZVGki+qb4xY/VXjGcTpqg7+i/+1xQHS8Ydaro87h4H8kwJMBHQq5uGKOBYQHu8/MyAhfDgNRQIFSCRzycB+ANs1QFmgMNLm20j67ID5ipKeRvfGTkUXiZWGIvti789noTRdE7rODO4EhWuET9Yvt9GJ7NE88tkM0OPvHSNbtjMkur9jWT/it9PX5yMtwweXrpWrcoPLcgq9MDX1V5wrT0dEx83fFzUVa4+KJTLWBmfhf3ZM+rZpR8Vkc/CWkMWyNhq9UaXD4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(13015025)(13018025)(13024025)(13023025)(13017025)(3002001)(10201501046)(6055026);SRVR:MWHPR03MB2448;BCL:0;PCL:0;RULEID:(400006);SRVR:MWHPR03MB2448; X-Forefront-PRVS: 00851CA28B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR03MB2448;23:fJd/HODRbKlV2ZEwC/6hqgU4CJPn8ukOK2BnG8vIZ?= =?us-ascii?Q?ktE8FXB6gn+GGbXOJUjQ+YYHL+PPnhR1eCdxxsyRlffMj9nF7AdtIXgeJjWP?= =?us-ascii?Q?9C834UxttauGX8CO6UY1/X3iEDgJwrhDNXFWbA6/fO2gtyeL8Vy1VG1qLjqf?= =?us-ascii?Q?EwfgsPzdBK2w/Wt0IykTSqQ7EHL3vKLtj0b5W/cF0BYM5w4YGsdO4zMGIGg7?= =?us-ascii?Q?Nfwen1ObhCciv9+hpPprdCj/TbJuTC8YOZdrnZvk96Mi3Q03vhEObz4k6aiw?= =?us-ascii?Q?tJD7brohbSJHGuAU1va/pFjI7aLBH/LLaZKX9u3RkH/v+udAmjhYAUIQORt9?= =?us-ascii?Q?ezxzlrwPblv525RwlbS1j7JNXuRnlMMlEPgVExd/ryYvVUGm2iF0r9A1bpVn?= =?us-ascii?Q?MtG8M+VMjgR+AuOz9om9DiV+MfDENTkuZDjA97wdUA/oeoz1Rb7InAxKfr1U?= =?us-ascii?Q?1dVRubSDl1F8BRHOrZQQV34IU5fZhkD8XMxygnpor4gK83OjGxmZiS/bCbQ7?= =?us-ascii?Q?7XAsrkhlsQSwoGlAA/44nRdaDLfV7K86ISASQy6L4O53GRM2nvmdOYW6WBdy?= =?us-ascii?Q?MrjBVQ6vyB0DMKjkYHmNBQ6jpNMo3a0mG95RWmXCZPUvFICHubfpPDdHjVVi?= =?us-ascii?Q?J7P6kLtwtrLNpctEc03pM5Eg8Dn+OBytXGeLpFeQ2lql+JDMbvulpFGudlXI?= =?us-ascii?Q?TJgynOYJGkVF6Q9VzkoYGjnWG02TlfigPvAmUL14bQDdfhT6AzM2XmXQo7pR?= =?us-ascii?Q?IC/yzS4MhEKB7hzd4aGRTxrgjuvsN9r37fl1ygGuisvbpBufeU9GLEcAEqZx?= =?us-ascii?Q?7L90nChcbRv9qn2vVvHAoFlEMDwvboZILOPP9LYKqLj6yrGvxcU/kP9vLdxP?= =?us-ascii?Q?2w4HZr946NudbtSP4ysLCzlJP09+kXBfT0UokT7i0FL+FTyTmY5g9wMgdrNt?= =?us-ascii?Q?ZSBSlUqfn9Jg/5pc/K3c47odeZKk9lUna8EQ6wpmRmXljZ2xswxgtWRIYIcT?= =?us-ascii?Q?Qy0iK1ctrUjncU4JXFwDkF7D7gpkgll33pm7nEh2TJ7O82hzWnc4WoZnIdsi?= =?us-ascii?Q?ElCW+kKQ6YnhoEkl6G3DKS7ZYQJmATjmh8B2mSSYXWRO7oKoP3OMI7Cn6Q3x?= =?us-ascii?Q?76wRknX/Nzt5pAMDgjnOCkQHA+kVSqPNjs5RKkk9xRXeThZybYEIQIwp7/aZ?= =?us-ascii?Q?MCwJMfaFVefUttLHNmWO8+KGr/jqXsRtpGZxTVUrmycryIq+ifI1szwJLfU1?= =?us-ascii?Q?e9wYeMvxH5DHaytrQIDmpjkWT0KGryvq5zRjCJI?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2448;6:G3dpymlICA79FFIIo2XJbe602RdrF4rcoKd721uM+q9Sgyll57HALVkWEs8cjoYcT5jTUN5Wy2TGSNOQWv4uclmo+asVrfUUYInMSRcQeYp5lD3wYafLqNKSOT1Pg7lI7684absqiQvZtlf6TVAkXKDqwOIhIVtN9HB0JEwLL37WDoRV867o6qEpZBcfe05qgk0IaiUvSxv88COU0RAHwriu6rcdwkzg0yNMjjF+paaKGlCO5UDSUJryMFvFKeZCyLYWh3fuv+yUODJYjg+5jnt6yjbCIHzLyciO0kDL84Jdx5VzPUddRekjB6P5Oyc9;5:sZmosGzkTIRfLytIjNSC2Xipbe+pXi+Z+fywpAh5ynH1dtIy5GdxecuJQSgBrDzOOJ2vpRfMr0qh7OS2xIz9uNCK/GIMbin/uezajoGxXXCnAclVjGH6b9t3NOlHObP/5w5SzVI+9tQeU5vIhYAbtLtM3ZYuVVN6QV3kRCNc9jn0mHcNS+6675iQiMPbtEhg;24:/YXnKsctN5oRbzm9m/NzJ+regtL3MRKJoGENNC91C09Dbg2MDoBEAJqlCxEpNM+yMQ+kSfrBtnUnOq9sF19Uu64wyWPMNisovMCrLbpXDsA=;7:5ZK4qAGqFmFNLoj4y5CQKIJ262/2rmCxToG8tjyLXsI5ie8pAn7aKCaB3PCqbv5LEWEkrS+lW8bWvUh2TmZ3XF//HvGp0rqyCVX3lobdicjL/iREA7chbbxMhNxZvHB02DucUMQsKrJLTSB8S3hj4S9gaIshu21KAu7iVxppa5cxp2eZO7Zo3uvkHyA+fChfvbrrbichV+UxNeZiC2L2lcKwj7uu8Pog5SKJwS9z3N3iB7cDNWD9rjqMWNeu38OcLGwOcxwASdO6he6WgLpN4vcztF226LhWa2lF4jMEbsyck93uETLE68nN5Ot1awTVFC8oM6L3aXsPz0Mb+ek0Nw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2016 07:33:16.7877 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2448 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For unknown compatibles avoid crashing and default to SGMII. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/mac.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index e4378c2..8fe6b3e 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -663,6 +663,7 @@ static int mac_probe(struct platform_device *_of_dev) const u8 *mac_addr; u32 val; u8 fman_id; + int phy_if; dev = &_of_dev->dev; mac_node = dev->of_node; @@ -842,13 +843,14 @@ static int mac_probe(struct platform_device *_of_dev) } /* Get the PHY connection type */ - priv->phy_if = of_get_phy_mode(mac_node); - if (priv->phy_if < 0) { + phy_if = of_get_phy_mode(mac_node); + if (phy_if < 0) { dev_warn(dev, - "of_get_phy_mode() for %s failed. Defaulting to MII\n", + "of_get_phy_mode() for %s failed. Defaulting to SGMII\n", mac_node->full_name); - priv->phy_if = PHY_INTERFACE_MODE_MII; + phy_if = PHY_INTERFACE_MODE_SGMII; } + priv->phy_if = phy_if; priv->speed = phy2speed[priv->phy_if]; priv->max_speed = priv->speed; -- 2.1.0