From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755313AbbJ1Cqp (ORCPT ); Tue, 27 Oct 2015 22:46:45 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:47518 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754305AbbJ1Cqn (ORCPT ); Tue, 27 Oct 2015 22:46:43 -0400 From: "Rafael J. Wysocki" To: Insu Yun Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu Subject: Re: [PATCH] acpi:correctly check failed allocation Date: Wed, 28 Oct 2015 04:15:40 +0100 Message-ID: <14755743.x0IPL3PNjt@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1444925970-28676-1-git-send-email-wuninsu@gmail.com> References: <1444925970-28676-1-git-send-email-wuninsu@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, October 15, 2015 12:19:30 PM Insu Yun wrote: > Since kobject_create_and_add can be failed in memory pressure, > return value need to be checked and return ENOMEM. > > Signed-off-by: Insu Yun > --- > drivers/acpi/sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c > index 40a4265..e712a7b 100644 > --- a/drivers/acpi/sysfs.c > +++ b/drivers/acpi/sysfs.c > @@ -878,6 +878,8 @@ int __init acpi_sysfs_init(void) > return result; > > hotplug_kobj = kobject_create_and_add("hotplug", acpi_kobj); > + if (!hotplug_kobj) > + return -ENOMEM; > result = sysfs_create_file(hotplug_kobj, &force_remove_attr.attr); > if (result) > return result; > Applied (with whitespace fixed), thanks! Rafael