mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Lesiak <chris.lesiak@licor.com>
To: Jiri Kosina <trivial@kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Chris Lesiak <chris.lesiak@licor.com>
Subject: [PATCH] lib: crc-itu-t: Fix polynomial comment
Date: Tue, 4 Oct 2016 12:11:32 -0500	[thread overview]
Message-ID: <1475601092-8166-1-git-send-email-chris.lesiak@licor.com> (raw)

The hexidecimal representation (0x1021) can be a bit confusing
because the leading 1 (x^16) is not shown.

0x1021
  | ||_ x^0  (Usually known as 1)
  | |__ x^5
  |____ x^12
        x^16 (Implicit in size of CRC)

Signed-off-by: Chris Lesiak <chris.lesiak@licor.com>
---
 include/linux/crc-itu-t.h | 2 +-
 lib/crc-itu-t.c           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/crc-itu-t.h b/include/linux/crc-itu-t.h
index a9953c7..7f89fab 100644
--- a/include/linux/crc-itu-t.h
+++ b/include/linux/crc-itu-t.h
@@ -3,7 +3,7 @@
  *
  * Implements the standard CRC ITU-T V.41:
  *   Width 16
- *   Poly  0x1021 (x^16 + x^12 + x^15 + 1)
+ *   Poly  0x1021 (x^16 + x^12 + x^5 + 1)
  *   Init  0
  *
  * This source code is licensed under the GNU General Public License,
diff --git a/lib/crc-itu-t.c b/lib/crc-itu-t.c
index b3219d0..7ff2cf9 100644
--- a/lib/crc-itu-t.c
+++ b/lib/crc-itu-t.c
@@ -9,7 +9,7 @@
 #include <linux/module.h>
 #include <linux/crc-itu-t.h>
 
-/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^15 + 1) */
+/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^5 + 1) */
 const u16 crc_itu_t_table[256] = {
 	0x0000, 0x1021, 0x2042, 0x3063, 0x4084, 0x50a5, 0x60c6, 0x70e7,
 	0x8108, 0x9129, 0xa14a, 0xb16b, 0xc18c, 0xd1ad, 0xe1ce, 0xf1ef,
-- 
2.5.5

                 reply	other threads:[~2016-10-04 19:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475601092-8166-1-git-send-email-chris.lesiak@licor.com \
    --to=chris.lesiak@licor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome