From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: sukadev@linux.vnet.ibm.com, jolsa@redhat.com,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 2/3] perf, tools: Handle completion of upper case events
Date: Wed, 5 Oct 2016 12:47:11 -0700 [thread overview]
Message-ID: <1475696832-9188-3-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1475696832-9188-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
Vendor events are often specified in upper case. perf list outputs them
in lower case. Handle this case in perf-completion.sh so that
completion on the upper case events still works.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/perf-completion.sh | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
index 3ba80b2359cc..48e7a01b5c91 100644
--- a/tools/perf/perf-completion.sh
+++ b/tools/perf/perf-completion.sh
@@ -161,7 +161,11 @@ __perf_main ()
# List possible events for -e option
elif [[ $prev == @("-e"|"--event") &&
$prev_skip_opts == @(record|stat|top) ]]; then
- evts=$($cmd list --raw-dump)
+ # handle upper case events
+ case "$cur" in
+ [A-Z]*) evts=$($cmd list --raw-dump | tr a-z A-Z) ;;
+ *) evts=$($cmd list --raw-dump) ;;
+ esac
__perfcomp_colon "$evts" "$cur"
else
# List subcommands for perf commands
--
2.5.5
next prev parent reply other threads:[~2016-10-05 19:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 19:47 Some minor fixes for the perf tools json event code Andi Kleen
2016-10-05 19:47 ` [PATCH 1/3] perf, tools: Handle events including .c and .o Andi Kleen
2016-10-05 22:47 ` Arnaldo Carvalho de Melo
2016-10-06 16:55 ` Andi Kleen
2016-10-06 20:07 ` Arnaldo Carvalho de Melo
2016-10-06 20:18 ` Arnaldo Carvalho de Melo
2016-10-08 4:02 ` Wangnan (F)
2016-10-08 4:16 ` [PATCH] " Wang Nan
2016-10-17 14:52 ` [tip:perf/urgent] perf jevents: " tip-bot for Wang Nan
2016-10-05 19:47 ` Andi Kleen [this message]
2016-10-05 21:50 ` [PATCH 2/3] perf, tools: Handle completion of upper case events Arnaldo Carvalho de Melo
2016-10-05 22:18 ` Andi Kleen
2016-10-05 22:35 ` Arnaldo Carvalho de Melo
2016-10-05 19:47 ` [PATCH 3/3] perf, tools: Fix Intel fixed counter conversions Andi Kleen
2016-10-06 22:41 ` [tip:perf/urgent] perf jevents: Fix Intel JSON " tip-bot for Andi Kleen
2016-10-06 19:23 [PATCH 1/3] perf, tools: Add support for perf list json Andi Kleen
2016-10-06 19:23 ` [PATCH 2/3] perf, tools: Handle completion of upper case events Andi Kleen
2016-10-06 20:05 ` Arnaldo Carvalho de Melo
2016-10-18 23:20 [PATCH 1/3] perf, tools: Add support for perf list vendor Andi Kleen
2016-10-18 23:21 ` [PATCH 2/3] perf, tools: Handle completion of upper case events Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475696832-9188-3-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®