From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbcJJF4H (ORCPT ); Mon, 10 Oct 2016 01:56:07 -0400 Received: from smtprelay0161.hostedemail.com ([216.40.44.161]:60963 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750991AbcJJF4G (ORCPT ); Mon, 10 Oct 2016 01:56:06 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3870:4321:5007:10004:10400:10848:11026:11658:11914:12043:12048:12296:12438:12740:12760:13069:13311:13357:13439:14659:14721:21080:21433:30003:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: game45_8c45943d5e53c X-Filterd-Recvd-Size: 1616 Message-ID: <1476078962.2856.20.camel@perches.com> Subject: Re: [PATCH V3] staging: ks7010: use netdev_* instead of printk() From: Joe Perches To: Sabitha George , gregkh@linuxfoundation.org, wsa+renesas@sang-engineering.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 09 Oct 2016 22:56:02 -0700 In-Reply-To: <1476078260-8827-1-git-send-email-sabitha.george@gmail.com> References: <1476078260-8827-1-git-send-email-sabitha.george@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.0-2ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-10-10 at 11:14 +0530, Sabitha George wrote: > 1. Fixes checkpatch warning on printk usage in ks_hostif.c > 2. Dropped "ks_wlan" prefix from the messages > 3. Removed the "Memory squeeze,dropping packet" messages [] > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c [] > @@ -549,7 +545,8 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv) > dev->dev_addr[5] = priv->eth_addr[5]; > dev->dev_addr[6] = 0x00; > dev->dev_addr[7] = 0x00; > - printk(KERN_INFO "ks_wlan: MAC ADDRESS = %pM\n", priv->eth_addr); > + netdev_info(dev, "MAC ADDRESS = %pM\n", > + priv->eth_addr); Do please use all 80 columns where possible. netdev_info(dev, "MAC ADDRESS = %pM\n", priv->eth_addr);