From: Joe Perches <joe@perches.com>
To: Jan Kara <jack@suse.cz>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: super.c: Update logging style using PR_CONT
Date: Wed, 12 Oct 2016 07:32:10 -0700 [thread overview]
Message-ID: <1476282730.16823.7.camel@perches.com> (raw)
In-Reply-To: <20161012104157.GB14664@quack2.suse.cz>
On Wed, 2016-10-12 at 12:41 +0200, Jan Kara wrote:
> On Tue 11-10-16 18:57:58, Joe Perches wrote:
> > Recent commit require line continuing printks to use PR_CONT.
> >
> > Update super.c to use PR_CONT and use vsprintf extension %pV
> > to avoid a printk/vprintk/printk("\n") sequence as well.
>
>
> Looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Except the subject and commit bodyis broken and should use KERN_CONT not PR_CONT
Ted, can you please fix when applying or do you want a resubmit?
next prev parent reply other threads:[~2016-10-12 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 1:57 Joe Perches
2016-10-12 10:41 ` Jan Kara
2016-10-12 14:32 ` Joe Perches [this message]
2016-10-12 22:13 ` Theodore Ts'o
2016-10-13 3:14 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476282730.16823.7.camel@perches.com \
--to=joe@perches.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome