mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <lkml@xs4all.nl>
To: Jens Axboe <axboe@fb.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org
Subject: Add "lightnvm: ensure that nvm_dev_ops can be used without CONFIG_NVM" to v4.4.y stable tree?
Date: Fri, 14 Oct 2016 15:28:41 +0200	[thread overview]
Message-ID: <1476451721.11366.15.camel@xs4all.nl> (raw)

Hi,

I had a build of v4.4.24, with CONFIG_NVM not set, fail like this:
    drivers/block/null_blk.c:569:27: error: storage size of 'null_lnvm_dev_ops' isn't known
     static struct nvm_dev_ops null_lnvm_dev_ops;
                               ^~~~~~~~~~~~~~~~~
    scripts/Makefile.build:264: recipe for target 'drivers/block/null_blk.o' failed
    make[2]: *** [drivers/block/null_blk.o] Error 1
    scripts/Makefile.build:403: recipe for target 'drivers/block' failed
    make[1]: *** [drivers/block] Error 2
    Makefile:959: recipe for target 'drivers' failed
    make: *** [drivers] Error 2

Jens' commit a7fd9a4f3e81 ("lightnvm: ensure that nvm_dev_ops can be
used without CONFIG_NVM") fixed that for me (it did require a small
context change to get it applied to v4.4.24). Does it make sense to add
that commit to the v4.4.y stable tree?

Thanks,


Paul Bolle

             reply	other threads:[~2016-10-14 13:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14 13:28 Paul Bolle [this message]
2016-10-14 13:47 ` Greg KH
2016-10-14 16:30   ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476451721.11366.15.camel@xs4all.nl \
    --to=lkml@xs4all.nl \
    --cc=axboe@fb.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®