From: Morten Rasmussen <morten.rasmussen@arm.com>
To: peterz@infradead.org, mingo@redhat.com
Cc: dietmar.eggemann@arm.com, yuyang.du@intel.com,
vincent.guittot@linaro.org, mgalbraith@suse.de,
sgurrappadi@nvidia.com, freedom.tan@mediatek.com,
keita.kobayashi.ym@renesas.com, linux-kernel@vger.kernel.org,
Morten Rasmussen <morten.rasmussen@arm.com>
Subject: [PATCH v5 6/6] sched/fair: Fix wrong comment for capacity_margin
Date: Fri, 14 Oct 2016 14:41:12 +0100 [thread overview]
Message-ID: <1476452472-24740-7-git-send-email-morten.rasmussen@arm.com> (raw)
In-Reply-To: <1476452472-24740-1-git-send-email-morten.rasmussen@arm.com>
The comment for capacity_margin introduced in "sched/fair: Let
asymmetric cpu configurations balance at wake-up" got its usage the
wrong way round.
cc: Ingo Molnar <mingo@redhat.com>
cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Morten Rasmussen <morten.rasmussen@arm.com>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index e0abff77764f..08408d6405a5 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -116,7 +116,7 @@ unsigned int sysctl_sched_cfs_bandwidth_slice = 5000UL;
/*
* The margin used when comparing utilization with CPU capacity:
- * util * 1024 < capacity * margin
+ * util * margin < capacity * 1024
*/
unsigned int capacity_margin = 1280; /* ~20% */
--
2.7.4
next prev parent reply other threads:[~2016-10-14 13:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 13:41 [PATCH v5 0/6] sched: Clean-ups and asymmetric cpu capacity support Morten Rasmussen
2016-10-14 13:41 ` [PATCH v5 1/6] sched/fair: Compute task/cpu utilization at wake-up correctly Morten Rasmussen
2016-11-16 12:12 ` [tip:sched/core] " tip-bot for Morten Rasmussen
2016-10-14 13:41 ` [PATCH v5 2/6] sched/fair: Consider spare capacity in find_idlest_group() Morten Rasmussen
2016-11-16 12:13 ` [tip:sched/core] " tip-bot for Morten Rasmussen
2016-10-14 13:41 ` [PATCH v5 3/6] sched: Add per-cpu min capacity to sched_group_capacity Morten Rasmussen
2016-11-16 12:13 ` [tip:sched/core] sched/fair: Add per-CPU " tip-bot for Morten Rasmussen
2016-10-14 13:41 ` [PATCH v5 4/6] sched/fair: Avoid pulling tasks from non-overloaded higher capacity groups Morten Rasmussen
2016-11-16 12:14 ` [tip:sched/core] " tip-bot for Morten Rasmussen
2016-10-14 13:41 ` [PATCH v5 5/6] sched/fair: Track peak per-entity utilization Morten Rasmussen
2016-10-17 8:51 ` Morten Rasmussen
2016-10-14 13:41 ` Morten Rasmussen [this message]
2016-11-16 12:14 ` [tip:sched/core] sched/fair: Fix incorrect comment for capacity_margin tip-bot for Morten Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476452472-24740-7-git-send-email-morten.rasmussen@arm.com \
--to=morten.rasmussen@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=freedom.tan@mediatek.com \
--cc=keita.kobayashi.ym@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgalbraith@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sgurrappadi@nvidia.com \
--cc=vincent.guittot@linaro.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®