From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932946AbcJNVUL (ORCPT ); Fri, 14 Oct 2016 17:20:11 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:54480 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753693AbcJNVUE (ORCPT ); Fri, 14 Oct 2016 17:20:04 -0400 From: Guenter Roeck To: Tony Lindgren Cc: Lee Jones , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Marcin Niestroj , Arnd Bergmann , Thomas Gleixner Subject: [PATCH] mfd: tps65217: Drop call to irq_set_parent() Date: Fri, 14 Oct 2016 14:18:06 -0700 Message-Id: <1476479886-10208-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.5.0 X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The call to irq_set_parent() causes the following build error if tps65217 is built as module. ERROR: ".irq_set_parent" [drivers/mfd/tps65217.ko] undefined! The problem was introduced with commit 6556bdacf646f ("mfd: tps65217: Add support for IRQs"). The author states: "I have added irq_set_parent() similarly as in drivers/base/regmap/regmap-irq.c. But to be honest I am not sure what it really does in case of tps65217." So let's drop it. Fixes: 6556bdacf646f ("mfd: tps65217: Add support for IRQs") Cc: Marcin Niestroj Cc: Arnd Bergmann Cc: Thomas Gleixner Signed-off-by: Guenter Roeck --- drivers/mfd/tps65217.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c index 9a4d8684dd32..2a57b444859c 100644 --- a/drivers/mfd/tps65217.c +++ b/drivers/mfd/tps65217.c @@ -170,7 +170,6 @@ static int tps65217_irq_map(struct irq_domain *h, unsigned int virq, irq_set_chip_data(virq, tps); irq_set_chip_and_handler(virq, &tps65217_irq_chip, handle_edge_irq); irq_set_nested_thread(virq, 1); - irq_set_parent(virq, tps->irq); irq_set_noprobe(virq); return 0; -- 2.5.0