mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
	netdev@vger.kernel.org, Timur Tabi <timur@codeaurora.org>
Subject: [PATCH 4/7] net: qcom/emac: Fix module autoload for OF registration
Date: Mon, 17 Oct 2016 11:05:43 -0300	[thread overview]
Message-ID: <1476713146-26632-5-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1476713146-26632-1-git-send-email-javier@osg.samsung.com>

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/net/ethernet/qualcomm/emac/qcom-emac.ko | grep alias
alias:          platform:qcom-emac

After this patch:

$ modinfo drivers/net/ethernet/qualcomm/emac/qcom-emac.ko | grep alias
alias:          platform:qcom-emac
alias:          of:N*T*Cqcom,fsm9900-emacC*
alias:          of:N*T*Cqcom,fsm9900-emac

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/net/ethernet/qualcomm/emac/emac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c
index 9bf3b2b82e95..4fede4b86538 100644
--- a/drivers/net/ethernet/qualcomm/emac/emac.c
+++ b/drivers/net/ethernet/qualcomm/emac/emac.c
@@ -575,6 +575,7 @@ static const struct of_device_id emac_dt_match[] = {
 	},
 	{}
 };
+MODULE_DEVICE_TABLE(of, emac_dt_match);
 
 #if IS_ENABLED(CONFIG_ACPI)
 static const struct acpi_device_id emac_acpi_match[] = {
-- 
2.7.4

  parent reply	other threads:[~2016-10-17 14:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 14:05 [PATCH 0/7] net: Fix module autoload for several platform drivers Javier Martinez Canillas
2016-10-17 14:05 ` [PATCH 1/7] net: nps_enet: Fix module autoload Javier Martinez Canillas
2016-10-17 14:05 ` [PATCH 2/7] net: ethernet: nb8800: " Javier Martinez Canillas
2016-10-17 14:09   ` Måns Rullgård
2016-10-17 14:05 ` [PATCH 3/7] net: hns: Fix hns_dsaf module autoload for OF registration Javier Martinez Canillas
2016-10-17 14:05 ` Javier Martinez Canillas [this message]
2016-10-17 14:40   ` [PATCH 4/7] net: qcom/emac: Fix " Timur Tabi
2016-10-17 14:05 ` [PATCH 5/7] net: hisilicon: Fix hns_mdio " Javier Martinez Canillas
2016-10-17 14:05 ` [PATCH 6/7] net: dsa: b53: Fix module autoload Javier Martinez Canillas
2016-10-17 14:05 ` [PATCH 7/7] net: dsa: bcm_sf2: Fix module autoload for OF registration Javier Martinez Canillas
2016-10-17 17:03 ` [PATCH 0/7] net: Fix module autoload for several platform drivers David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476713146-26632-5-git-send-email-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®