From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
devel@driverdev.osuosl.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Kamil Debski <kamil@wypas.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org
Subject: [PATCH 4/5] [media] s5p-cec: Fix module autoload
Date: Mon, 17 Oct 2016 12:44:11 -0300 [thread overview]
Message-ID: <1476719053-17600-5-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1476719053-17600-1-git-send-email-javier@osg.samsung.com>
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/staging/media/s5p-cec/s5p-cec.ko | grep alias
$
After this patch:
$ modinfo drivers/staging/media/s5p-cec/s5p-cec.ko | grep alias
alias: of:N*T*Csamsung,s5p-cecC*
alias: of:N*T*Csamsung,s5p-cec
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/staging/media/s5p-cec/s5p_cec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/s5p-cec/s5p_cec.c b/drivers/staging/media/s5p-cec/s5p_cec.c
index 1780a08b73c9..4e41f72dbfaa 100644
--- a/drivers/staging/media/s5p-cec/s5p_cec.c
+++ b/drivers/staging/media/s5p-cec/s5p_cec.c
@@ -263,6 +263,7 @@ static const struct of_device_id s5p_cec_match[] = {
},
{},
};
+MODULE_DEVICE_TABLE(of, s5p_cec_match);
static struct platform_driver s5p_cec_pdrv = {
.probe = s5p_cec_probe,
--
2.7.4
next prev parent reply other threads:[~2016-10-17 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 15:44 [PATCH 0/5] [media] Fix module autoload for media platform drivers Javier Martinez Canillas
2016-10-17 15:44 ` [PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration Javier Martinez Canillas
2016-10-17 16:08 ` Laurent Pinchart
2016-10-17 15:44 ` [PATCH 2/5] [media] v4l: rcar-fcp: " Javier Martinez Canillas
2016-10-17 16:08 ` Laurent Pinchart
2016-10-17 15:44 ` [PATCH 3/5] [media] rc: meson-ir: Fix module autoload Javier Martinez Canillas
2016-10-17 16:40 ` Kevin Hilman
2016-10-17 15:44 ` Javier Martinez Canillas [this message]
2016-10-17 15:44 ` [PATCH 5/5] [media] st-cec: " Javier Martinez Canillas
2016-10-18 7:52 ` Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476719053-17600-5-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=kamil@wypas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®