mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: frowand.list@gmail.com, Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add missing space at end of pr_fmt().
Date: Mon, 17 Oct 2016 10:04:21 -0700	[thread overview]
Message-ID: <1476723861.4414.1.camel@perches.com> (raw)
In-Reply-To: <1476717010-3580-1-git-send-email-frowand.list@gmail.com>

On Mon, 2016-10-17 at 08:10 -0700, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@am.sony.com>
> 
> Make pr_fmt() in fdt.c consistent with all other files in drivers/of/

Hi Frank.

Patches should use the subsystem as a subject prefix to make
the subsystem more obvious when using "git log".

This email subject could be something like:

"Subject: [PATCH] of: fdt: Add missing space at end of pr_fmt()"

Please check the git log to see examples for drivers/of/fdt.c
and pick the prefix style you think appropriate.

> Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
> ---
>  drivers/of/fdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index c89d5d231a0e..9f98e437e1f1 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -9,7 +9,7 @@
>   * version 2 as published by the Free Software Foundation.
>   */
>  
> -#define pr_fmt(fmt)	"OF: fdt:" fmt
> +#define pr_fmt(fmt)	"OF: fdt: " fmt
>  
>  #include <linux/crc32.h>
>  #include <linux/kernel.h>
> 

  reply	other threads:[~2016-10-17 17:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 15:10 frowand.list
2016-10-17 17:04 ` Joe Perches [this message]
2016-10-17 19:08 ` Frank Rowand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476723861.4414.1.camel@perches.com \
    --to=joe@perches.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome