From: Luca Abeni <luca.abeni@unitn.it>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@arm.com>,
Claudio Scordino <claudio@evidence.eu.com>,
Steven Rostedt <rostedt@goodmis.org>,
Luca Abeni <luca.abeni@unitn.it>
Subject: [RFC v3 0/6] CPU reclaiming for SCHED_DEADLINE
Date: Mon, 24 Oct 2016 16:06:32 +0200 [thread overview]
Message-ID: <1477317998-7487-1-git-send-email-luca.abeni@unitn.it> (raw)
Hi all,
this patchset implements CPU reclaiming (using the GRUB algorithm[1])
for SCHED_DEADLINE: basically, this feature allows SCHED_DEADLINE tasks
to consume more than their reserved runtime, up to a maximum fraction
of the CPU time (so that other tasks are left some spare CPU time to
execute), if this does not break the guarantees of other SCHED_DEADLINE
tasks.
The patchset applies on top of tip/master.
The implemented CPU reclaiming algorithm is based on tracking the
utilization U_act of active tasks (first 2 patches), and modifying the
runtime accounting rule (see patch 0004). The original GRUB algorithm is
modified as described in [2] to support multiple CPUs (the original
algorithm only considered one single CPU, this one tracks U_act per
runqueue) and to leave an "unreclaimable" fraction of CPU time to non
SCHED_DEADLINE tasks (see patch 0005: the original algorithm can consume
100% of the CPU time, starving all the other tasks).
Patch 0003 uses the newly introduced "inactive timer" (introduced in
patch 0002) to fix dl_overflow() and __setparam_dl().
Patch 0006 allows to enable CPU reclaiming only on selected tasks.
Changes since v2:
in general, I tried to address all the comments I received, and to add
some more comments in "critical" parts of the code. In particular, I:
- Updated to latest tip/master. This required some changes (for example,
using "struct rq_flags" instead of "unsigned long" for task_rq_lock())
- Merged patches 0001 and 0002, as suggested by Juri
- Added some comments about GRUB in the changelog of the patch adding
GRUB accounting
- Exchanged the order of two patches ("Make GRUB a task's flag" and
"Do not reclaim the whole CPU bandwidth"), as suggested by Juri
- Removed unused code ("if (task_on_rq_queued(p))" in task_dead_dl(),
noticed by Peter) from patch 0001
- Properly consider the migrations of queued dl tasks when updating
the active utilization. This should address Peter's concern from
http://lkml.iu.edu/hypermail/linux/kernel/1604.0/02612.html
- Simplified the code for setting up the inactive timer, as suggested
by Peter: http://lkml.iu.edu/hypermail/linux/kernel/1604.0/02620.html
- Use hrtimer_is_queued() instead of "(hrtimer_active() &&
!hrtimer_callback_running())", as pointed out by Peter:
http://lkml.iu.edu/hypermail/linux/kernel/1604.0/02805.html
- Fix select_task_rq_dl() (using "task_cpu(p) != cpu" instead
of "rq != cpu_rq(cpu)"), as pointed out by Peter:
http://lkml.iu.edu/hypermail/linux/kernel/1604.0/02822.html
I also changed the logic used in select_task_rq_dl()
(that now does not increase the active utilization in the selected
runqueue)
- Because of the changes in the code, I am not sure if the race condition
pointed out by Peter can still happen. I tried to trigger it in many ways,
but I failed... If it turns out that the race is still possible, I'll fix
it in the next round of patches, by introducing a new "is_contending" field
(protected by pi_mutex) in the dl scheduling entity.
[1] Lipari, G., & Baruah, S. (2000). Greedy reclamation of unused bandwidth in constant-bandwidth servers. In Real-Time Systems, 2000. Euromicro RTS 2000. 12th Euromicro Conference on (pp. 193-200). IEEE.
[2] Abeni, L., Lelli, J., Scordino, C., & Palopoli, L. (2014, October). Greedy CPU reclaiming for SCHED DEADLINE. In Proceedings of the Real-Time Linux Workshop (RTLWS), Dusseldorf, Germany.
Luca Abeni (6):
Track the active utilisation
Improve the tracking of active utilisation
Fix the update of the total -deadline utilization
GRUB accounting
Do not reclaim the whole CPU bandwidth
Make GRUB a task's flag
include/linux/sched.h | 1 +
include/uapi/linux/sched.h | 1 +
kernel/sched/core.c | 44 ++++-----
kernel/sched/deadline.c | 220 ++++++++++++++++++++++++++++++++++++++++-----
kernel/sched/sched.h | 13 +++
5 files changed, 234 insertions(+), 45 deletions(-)
--
2.7.4
next reply other threads:[~2016-10-24 14:07 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 14:06 Luca Abeni [this message]
2016-10-24 14:06 ` [RFC v3 1/6] Track the active utilisation Luca Abeni
2016-10-25 9:09 ` Daniel Bristot de Oliveira
2016-10-25 9:29 ` luca abeni
2016-10-25 13:58 ` Steven Rostedt
2016-10-25 18:04 ` Luca Abeni
2016-11-18 14:23 ` Peter Zijlstra
2016-11-18 15:10 ` luca abeni
2016-11-18 15:28 ` Peter Zijlstra
2016-11-18 16:42 ` Steven Rostedt
2016-12-05 22:30 ` luca abeni
2016-12-06 8:35 ` Peter Zijlstra
2016-12-06 8:57 ` luca abeni
2016-12-06 13:47 ` luca abeni
2016-11-01 16:45 ` Juri Lelli
2016-11-01 21:10 ` luca abeni
2016-11-08 17:56 ` Juri Lelli
2016-11-08 18:17 ` Luca Abeni
2016-11-08 18:53 ` Juri Lelli
2016-11-08 19:09 ` Luca Abeni
2016-11-08 20:02 ` Juri Lelli
2016-11-09 15:25 ` luca abeni
2016-11-09 16:29 ` luca abeni
2016-11-18 14:55 ` Peter Zijlstra
2016-11-18 13:55 ` Peter Zijlstra
2016-11-18 15:06 ` luca abeni
2016-10-24 14:06 ` [RFC v3 2/6] Improve the tracking of " Luca Abeni
2016-11-01 16:46 ` Juri Lelli
2016-11-01 21:46 ` luca abeni
2016-11-02 2:35 ` luca abeni
2016-11-10 10:04 ` Juri Lelli
2016-11-10 11:56 ` Juri Lelli
2016-11-10 12:15 ` luca abeni
2016-11-10 12:34 ` Juri Lelli
2016-11-10 12:45 ` luca abeni
2016-11-02 2:41 ` luca abeni
2016-11-18 15:36 ` Peter Zijlstra
2016-11-18 15:56 ` luca abeni
2016-11-18 15:47 ` Peter Zijlstra
2016-11-18 16:06 ` luca abeni
2016-11-18 18:49 ` Peter Zijlstra
2016-10-24 14:06 ` [RFC v3 3/6] Fix the update of the total -deadline utilization Luca Abeni
2016-10-24 14:06 ` [RFC v3 4/6] GRUB accounting Luca Abeni
2016-10-24 14:06 ` [RFC v3 5/6] Do not reclaim the whole CPU bandwidth Luca Abeni
2016-10-24 14:06 ` [RFC v3 6/6] Make GRUB a task's flag Luca Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477317998-7487-1-git-send-email-luca.abeni@unitn.it \
--to=luca.abeni@unitn.it \
--cc=claudio@evidence.eu.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®