From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757919AbcJXXFc (ORCPT ); Mon, 24 Oct 2016 19:05:32 -0400 Received: from smtprelay0116.hostedemail.com ([216.40.44.116]:37842 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755352AbcJXXFb (ORCPT ); Mon, 24 Oct 2016 19:05:31 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1543:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3873:4321:5007:7576:8957:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12048:12295:12296:12438:12555:12740:12760:13255:13439:14181:14659:14721:21080:21220:21433:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: trade36_2f769ff5c7a4f X-Filterd-Recvd-Size: 4660 Message-ID: <1477350325.2111.8.camel@perches.com> Subject: Re: [PATCH] drm/amd/powerplay: fix spelling mistake and add KERN_WARNING to printks From: Joe Perches To: Colin King , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= , David Airlie , Rex Zhu , Nils =?ISO-8859-1?Q?Wallm=E9nius?= , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Date: Mon, 24 Oct 2016 16:05:25 -0700 In-Reply-To: <20161024223037.9955-1-colin.king@canonical.com> References: <20161024223037.9955-1-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-10-24 at 23:30 +0100, Colin King wrote: > From: Colin Ian King > > Fix trivial spelling mistake cant't -> can't and add KERN_WARNING to > printk messages. trivia: > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c [] > @@ -2125,7 +2125,7 @@ uint32_t fiji_get_offsetof(uint32_t type, uint32_t member) > return offsetof(SMU73_Discrete_DpmTable, LowSclkInterruptThreshold); > } > } > - printk("cant't get the offset of type %x member %x \n", type, member); > + printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member); you can also delete the spaces before a newline. > return 0; > } > > @@ -2150,7 +2150,7 @@ uint32_t fiji_get_mac_definition(uint32_t value) > return SMU73_MAX_LEVELS_MVDD; > } > > - printk("cant't get the mac of %x \n", value); > + printk(KERN_WARNING "can't get the mac of %x \n", value); et al, below > return 0; > } > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c [] > @@ -2140,7 +2140,7 @@ uint32_t iceland_get_offsetof(uint32_t type, uint32_t member) > return offsetof(SMU71_Discrete_DpmTable, LowSclkInterruptThreshold); > } > } > - printk("cant't get the offset of type %x member %x \n", type, member); > + printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member); > return 0; > } > > @@ -2163,7 +2163,7 @@ uint32_t iceland_get_mac_definition(uint32_t value) > return SMU71_MAX_LEVELS_MVDD; > } > > - printk("cant't get the mac of %x \n", value); > + printk(KERN_WARNING "can't get the mac of %x \n", value); > return 0; > } > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c > index 4ccc0b7..7b4efcc 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c > @@ -2174,7 +2174,7 @@ uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member) > return offsetof(SMU74_Discrete_DpmTable, LowSclkInterruptThreshold); > } > } > - printk("cant't get the offset of type %x member %x \n", type, member); > + printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member); > return 0; > } > > @@ -2201,7 +2201,7 @@ uint32_t polaris10_get_mac_definition(uint32_t value) > return SMU7_UVD_MCLK_HANDSHAKE_DISABLE; > } > > - printk("cant't get the mac of %x \n", value); > + printk(KERN_WARNING "can't get the mac of %x \n", value); > return 0; > } > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c > index de2a24d..84868e8 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c > @@ -2651,7 +2651,7 @@ uint32_t tonga_get_offsetof(uint32_t type, uint32_t member) > return offsetof(SMU72_Discrete_DpmTable, LowSclkInterruptThreshold); > } > } > - printk("cant't get the offset of type %x member %x\n", type, member); > + printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member); > return 0; > } > > @@ -2675,7 +2675,7 @@ uint32_t tonga_get_mac_definition(uint32_t value) > case SMU_MAX_LEVELS_MVDD: > return SMU72_MAX_LEVELS_MVDD; > } > - printk("cant't get the mac value %x\n", value); > + printk(KERN_WARNING "can't get the mac value %x\n", value); > > return 0; > }