mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stuart Yoder <stuart.yoder@nxp.com>
To: <gregkh@linuxfoundation.org>
Cc: <german.rivera@nxp.com>, <devel@driverdev.osuosl.org>,
	<linux-kernel@vger.kernel.org>, <agraf@suse.de>, <arnd@arndb.de>,
	<leoyang.li@nxp.com>, <ioana.ciornei@nxp.com>,
	<catalin.horghidan@nxp.com>, Stuart Yoder <stuart.yoder@nxp.com>
Subject: [PATCH v2 08/12] staging: fsl-mc: improve message clarity by adding __func__
Date: Wed, 26 Oct 2016 11:20:30 -0500	[thread overview]
Message-ID: <1477498834-30425-9-git-send-email-stuart.yoder@nxp.com> (raw)
In-Reply-To: <1477498834-30425-1-git-send-email-stuart.yoder@nxp.com>

clarify some error messages by printing the actual function name
involved

Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
---
-v2
   -patch is result of split of original patch, updated
    commit messasge to reflect the change

 drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
index 245acbf..5267c503 100644
--- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
+++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
@@ -166,8 +166,7 @@ static int fsl_mc_driver_probe(struct device *dev)
 
 	error = mc_drv->probe(mc_dev);
 	if (error < 0) {
-		dev_err(dev, "MC object device probe callback failed: %d\n",
-			error);
+		dev_err(dev, "%s failed: %d\n", __func__, error);
 		return error;
 	}
 
@@ -185,9 +184,7 @@ static int fsl_mc_driver_remove(struct device *dev)
 
 	error = mc_drv->remove(mc_dev);
 	if (error < 0) {
-		dev_err(dev,
-			"MC object device remove callback failed: %d\n",
-			error);
+		dev_err(dev, "%s failed: %d\n", __func__, error);
 		return error;
 	}
 
-- 
1.9.0

  parent reply	other threads:[~2016-10-26 16:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 16:20 [PATCH v2 00/12] staging: fsl-mc: cleanup and uprev to MC v10.x Stuart Yoder
2016-10-26 16:20 ` [PATCH v2 01/12] staging: fsl-mc: update MAINTAINERS Stuart Yoder
2016-10-26 16:20 ` [PATCH v2 02/12] staging: fsl-mc: whitespace cleanup: remove blank lines Stuart Yoder
2016-10-26 16:20 ` [PATCH v2 03/12] staging: fsl-mc: whitespace cleanup: remove extraenous tabs Stuart Yoder
2016-10-26 16:20 ` [PATCH v2 04/12] staging: fsl-mc: whitespace cleanup: align function args Stuart Yoder
2016-10-26 16:20 ` [PATCH v2 05/12] staging: fsl-mc: whitespace cleanup: improve alignment in prototypes Stuart Yoder
2016-10-26 16:20 ` [PATCH v2 06/12] staging: fsl-mc: cleanup comment style Stuart Yoder
2016-10-26 16:20 ` [PATCH v2 07/12] staging: fsl-mc: improve pr_* messages Stuart Yoder
2016-10-26 16:20 ` Stuart Yoder [this message]
2016-10-26 16:20 ` [PATCH v2 09/12] staging: fsl-mc: cleanup: improve clarity of messages Stuart Yoder
2016-10-26 16:20 ` [PATCH v2 10/12] staging: fsl-mc: improve wording in comments Stuart Yoder
2016-10-26 16:20 ` [PATCH v2 11/12] staging: fsl-mc: update copyright dates Stuart Yoder
2016-10-26 16:20 ` [PATCH v2 12/12] staging: fsl-mc: uprev binary interface to match MC v10.x Stuart Yoder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477498834-30425-9-git-send-email-stuart.yoder@nxp.com \
    --to=stuart.yoder@nxp.com \
    --cc=agraf@suse.de \
    --cc=arnd@arndb.de \
    --cc=catalin.horghidan@nxp.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=german.rivera@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome