From: Bastien Nocera <hadess@hadess.net>
To: Franklin S Cooper Jr <fcooper@ti.com>,
dmitry.torokhov@gmail.com, robh+dt@kernel.org,
octavian.purdila@intel.com, irina.tirdea@intel.com,
merker@debian.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
nsekhar@ti.com, nm@ti.com
Subject: Re: [PATCH 1/4] Input: goodix - Restructure cfg checksum function
Date: Thu, 27 Oct 2016 12:32:50 +0200 [thread overview]
Message-ID: <1477564370.2458.8.camel@hadess.net> (raw)
In-Reply-To: <20161020195917.20051-2-fcooper@ti.com>
On Thu, 2016-10-20 at 14:59 -0500, Franklin S Cooper Jr wrote:
> Split generation of checksum into is own function. Currently it is used
"its own".
> only to determine if the checksum for the user provided configuration file
> is valid or not. However, support to dynamically alter the configuration
> file will be supported and needs a way to calculate the updated file's
> checksum. Therefore, by splitting calculating checksum into its own
> function the code can be reused.
>
After the fixup above:
Reviewed-by: Bastien Nocera <hadess@hadess.net>
next prev parent reply other threads:[~2016-10-27 13:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 19:59 [PATCH 0/4] Input: goodix - Support dynamic reconfiguration Franklin S Cooper Jr
2016-10-20 19:59 ` [PATCH 1/4] Input: goodix - Restructure cfg checksum function Franklin S Cooper Jr
2016-10-27 10:32 ` Bastien Nocera [this message]
2016-10-20 19:59 ` [PATCH 2/4] Input: goodix - Allow tweaking of configuration file dynamically Franklin S Cooper Jr
2016-10-27 10:33 ` Bastien Nocera
2016-10-27 16:58 ` Franklin S Cooper Jr
2016-10-27 17:41 ` Bastien Nocera
2016-10-20 19:59 ` [PATCH 3/4] Input: goodix - Tweak configuration to use passed in touchscreen resolution Franklin S Cooper Jr
2016-10-26 23:10 ` Rob Herring
2016-10-27 10:34 ` Bastien Nocera
2016-10-27 17:03 ` Franklin S Cooper Jr
2016-10-20 19:59 ` [PATCH 4/4] Input: goodix - Support interchanging x and y coordinates in hardware Franklin S Cooper Jr
2016-10-26 23:18 ` Rob Herring
2016-10-27 10:34 ` Bastien Nocera
2016-10-27 17:42 ` Franklin S Cooper Jr
2016-10-28 0:08 ` Bastien Nocera
2016-10-27 17:54 ` Franklin S Cooper Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477564370.2458.8.camel@hadess.net \
--to=hadess@hadess.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fcooper@ti.com \
--cc=irina.tirdea@intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=merker@debian.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=octavian.purdila@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome