From: Joe Perches <joe@perches.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Takashi Iwai <tiwai@suse.com>,
Clemens Ladisch <clemens@ladisch.de>,
alsa-devel <alsa-devel@alsa-project.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: sound: bebop: strncmp length oddity
Date: Sat, 29 Oct 2016 14:37:00 -0700 [thread overview]
Message-ID: <1477777020.23018.8.camel@perches.com> (raw)
15 isn't the length of the string, is that really what's desired?
linux/next/sound/firewire/bebob/bebop.c
-----------------------------
static bool
check_audiophile_booted(struct fw_unit *unit)
{
char name[24] = {0};
if (fw_csr_string(unit->directory, CSR_MODEL, name, sizeof(name)) < 0)
return false;
return strncmp(name, "FW Audiophile Bootloader", 15) != 0;
}
next reply other threads:[~2016-10-29 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 21:37 Joe Perches [this message]
2016-11-17 11:47 ` [alsa-devel] " Takashi Iwai
2016-11-17 20:07 ` Takashi Sakamoto
2016-11-17 21:34 ` Nicolas Iooss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477777020.23018.8.camel@perches.com \
--to=joe@perches.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®