From: Guenter Roeck <linux@roeck-us.net>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Alex Smith <alex.smith@imgtec.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
James Hogan <james.hogan@imgtec.com>
Subject: [PATCH] MIPS: VDSO: Always select -msoft-float
Date: Sun, 30 Oct 2016 09:05:51 -0700 [thread overview]
Message-ID: <1477843551-21813-1-git-send-email-linux@roeck-us.net> (raw)
Some toolchains fail to build mips images with the following build error.
arch/mips/vdso/gettimeofday.c:1:0: error: '-march=r3000' requires '-mfp32'
This is seen, for example, with the 'mipsel-linux-gnu-gcc (Debian 6.1.1-9)
6.1.1 20160705' toolchain as used by the 0Day build robot when building
decstation_defconfig.
Comparison of compile flags suggests that the major difference is a missing
'-soft-float', which is otherwise defined unconditionally.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: James Hogan <james.hogan@imgtec.com>
Fixes: ebb5e78cc634 ("MIPS: Initial implementation of a VDSO")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/mips/vdso/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
index c3dc12a8b7d9..9bdd6641400f 100644
--- a/arch/mips/vdso/Makefile
+++ b/arch/mips/vdso/Makefile
@@ -6,7 +6,8 @@ ccflags-vdso := \
$(filter -I%,$(KBUILD_CFLAGS)) \
$(filter -E%,$(KBUILD_CFLAGS)) \
$(filter -mmicromips,$(KBUILD_CFLAGS)) \
- $(filter -march=%,$(KBUILD_CFLAGS))
+ $(filter -march=%,$(KBUILD_CFLAGS)) \
+ -msoft-float
cflags-vdso := $(ccflags-vdso) \
$(filter -W%,$(filter-out -Wa$(comma)%,$(KBUILD_CFLAGS))) \
-O2 -g -fPIC -fno-strict-aliasing -fno-common -fno-builtin -G 0 \
--
2.5.0
next reply other threads:[~2016-10-30 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 16:05 Guenter Roeck [this message]
2016-11-01 22:40 ` Maciej W. Rozycki
2016-11-01 23:30 ` Guenter Roeck
2016-11-04 12:54 ` Maciej W. Rozycki
2016-11-04 13:42 ` Matthew Fortune
2016-11-04 15:26 ` Guenter Roeck
2016-11-04 16:09 ` Maciej W. Rozycki
2016-11-04 16:50 ` Guenter Roeck
2016-11-04 18:06 ` Maciej W. Rozycki
2016-11-04 16:55 ` Matthew Fortune
2016-11-04 18:33 ` Guenter Roeck
2016-11-04 19:07 ` Maciej W. Rozycki
2016-11-23 0:08 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477843551-21813-1-git-send-email-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alex.smith@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®