From: kys@exchange.microsoft.com
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com,
leann.ogasawara@canonical.com, sthemmin@microsoft.com
Cc: Alex Ng <alexng@messages.microsoft.com>,
Alex Ng <alexng@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH 07/15] Drivers: hv: vss: Operation timeouts should match host expectation
Date: Mon, 31 Oct 2016 00:41:42 -0700 [thread overview]
Message-ID: <1477899710-28675-7-git-send-email-kys@exchange.microsoft.com> (raw)
In-Reply-To: <1477899710-28675-1-git-send-email-kys@exchange.microsoft.com>
From: Alex Ng <alexng@messages.microsoft.com>
Increase the timeout of backup operations. When system is under I/O load,
it needs more time to freeze. These timeout values should also match the
host timeout values more closely.
Signed-off-by: Alex Ng <alexng@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/hv/hv_snapshot.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c
index 5c95ba1..eee238c 100644
--- a/drivers/hv/hv_snapshot.c
+++ b/drivers/hv/hv_snapshot.c
@@ -31,7 +31,10 @@
#define VSS_MINOR 0
#define VSS_VERSION (VSS_MAJOR << 16 | VSS_MINOR)
-#define VSS_USERSPACE_TIMEOUT (msecs_to_jiffies(10 * 1000))
+/*
+ * Timeout values are based on expecations from host
+ */
+#define VSS_FREEZE_TIMEOUT (15 * 60)
/*
* Global state maintained for transaction that is being processed. For a class
@@ -186,7 +189,8 @@ static void vss_send_op(void)
vss_transaction.state = HVUTIL_USERSPACE_REQ;
- schedule_delayed_work(&vss_timeout_work, VSS_USERSPACE_TIMEOUT);
+ schedule_delayed_work(&vss_timeout_work, op == VSS_OP_FREEZE ?
+ VSS_FREEZE_TIMEOUT * HZ : HV_UTIL_TIMEOUT * HZ);
rc = hvutil_transport_send(hvt, vss_msg, sizeof(*vss_msg), NULL);
if (rc) {
--
1.7.4.1
next prev parent reply other threads:[~2016-10-31 5:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 7:41 [PATCH 00/15] Drivers: hv: Some miscellaneous fixes and enhancements kys
2016-10-31 7:41 ` [PATCH 01/15] Drivers: hv: ring_buffer: count on wrap around mappings in get_next_pkt_raw() (v2) kys
2016-10-31 7:41 ` [PATCH 02/15] Drivers: hv: utils: reduce HV_UTIL_NEGO_TIMEOUT timeout kys
2016-10-31 7:41 ` [PATCH 03/15] Drivers: hv: utils: Fix the mapping between host version and protocol to use kys
2016-10-31 7:41 ` [PATCH 04/15] Drivers: hv: balloon: Disable hot add when CONFIG_MEMORY_HOTPLUG is not set kys
2016-10-31 7:41 ` [PATCH 05/15] Drivers: hv: balloon: Add logging for dynamic memory operations kys
2016-10-31 7:41 ` [PATCH 06/15] Drivers: hv: vss: Improve log messages kys
2016-10-31 7:41 ` kys [this message]
2016-10-31 7:41 ` [PATCH 08/15] Drivers: hv: balloon: Fix info request to show max page count kys
2016-10-31 7:41 ` [PATCH 09/15] tools: hv: remove unnecessary link flag kys
2016-10-31 7:41 ` [PATCH 10/15] tools: hv: fix a compile warning in snprintf kys
2016-10-31 7:41 ` [PATCH 11/15] tools: hv: remove unnecessary header files and netlink related code kys
2016-10-31 7:41 ` [PATCH 12/15] vmbus: make sysfs names consistent with PCI kys
2016-10-31 12:43 ` Greg KH
2016-10-31 15:04 ` KY Srinivasan
2016-10-31 7:41 ` [PATCH 13/15] Drivers: hv: vmbus: Base host signaling strictly on the ring state kys
2016-10-31 7:41 ` [PATCH 14/15] Drivers: hv: vmbus: On write cleanup the logic to interrupt the host kys
2016-10-31 7:41 ` [PATCH 15/15] Drivers: hv: vmbus: On the read path " kys
2016-10-31 12:45 ` [PATCH 00/15] Drivers: hv: Some miscellaneous fixes and enhancements Greg KH
2016-10-31 15:01 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477899710-28675-7-git-send-email-kys@exchange.microsoft.com \
--to=kys@exchange.microsoft.com \
--cc=alexng@messages.microsoft.com \
--cc=alexng@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=leann.ogasawara@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome