From: Babu Moger <babu.moger@oracle.com>
To: mingo@kernel.org, akpm@linux-foundation.org, ak@linux.intel.com,
jkosina@suse.cz, baiyaowei@cmss.chinamobile.com,
dzickus@redhat.com, atomlin@redhat.com, uobergfe@redhat.com,
tj@kernel.org, hidehiro.kawai.ez@hitachi.com, johunt@akamai.com,
davem@davemloft.net, sparclinux@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, sam@ravnborg.org, babu.moger@oracle.com
Subject: [PATCH v2 0/3] Clean up watchdog handlers
Date: Tue, 1 Nov 2016 14:13:43 -0700 [thread overview]
Message-ID: <1478034826-43888-1-git-send-email-babu.moger@oracle.com> (raw)
This is an attempt to cleanup watchdog handlers. Right now,
kernel/watchdog.c implements both softlockup and hardlockup detectors.
Softlockup code is generic. Hardlockup code is arch specific. Some
architectures don't use hardlockup detectors. They use their own watchdog
detectors. To make both these combination work, we have numerous #ifdefs
in kernel/watchdog.c.
We are trying here to make these handlers independent of each other.
Also provide an interface for architectures to implement their own
handlers. watchdog_nmi_enable and watchdog_nmi_disable will be defined
as weak such that architectures can override its definitions.
Thanks to Don Zickus for his suggestions.
Here are our previous discussions
http://www.spinics.net/lists/sparclinux/msg16543.html
http://www.spinics.net/lists/sparclinux/msg16441.html
v2:
Addressed few comments from Don Zickus.
1. Took care of bisectability issue. Previous patch2 is patch1 now.
Combined patch 1 and 3. Patch 4 is now patch 3.
2. Added pr_fmt back in watchdog_hld.c
3. Tweaked the file headers for watchdog.c and watchdog_hld.c.
4. Took care of couple of config compile issues.
drivers/edac/edac_device.o:(.discard+0x0): multiple definition of `__pcpu_unique_hrtimer_interrupts'
drivers/edac/edac_mc.o:(.discard+0x0): first defined here
This was a problem with uni processor config. Moved the definition of hrtimer_interrupts and
is_hardlockup into watchdog.c as softlockup code does most of the work here.
is_hardlockup kind of generic most part.
kernel/built-in.o: In function `watchdog_overflow_callback':
watchdog_hld.c:(.text+0x56940): undefined reference to `sysctl_hardlockup_all_cpu_backtrace'
Moved this definition to nmi.h.
v1:
Initial version
Babu Moger (3):
watchdog: Move shared definitions to nmi.h
watchdog: Move hardlockup detector to separate file
sparc: Implement watchdog_nmi_enable and watchdog_nmi_disable
arch/sparc/kernel/nmi.c | 44 ++++++++-
include/linux/nmi.h | 24 ++++
kernel/Makefile | 1 +
kernel/watchdog.c | 270 +++--------------------------------------------
kernel/watchdog_hld.c | 227 +++++++++++++++++++++++++++++++++++++++
5 files changed, 310 insertions(+), 256 deletions(-)
create mode 100644 kernel/watchdog_hld.c
next reply other threads:[~2016-11-01 21:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 21:13 Babu Moger [this message]
2016-11-01 21:13 ` [PATCH v2 1/3] watchdog: Move shared definitions to nmi.h Babu Moger
2016-11-01 21:13 ` [PATCH v2 2/3] watchdog: Move hardlockup detector to separate file Babu Moger
2016-11-01 21:13 ` [PATCH v2 3/3] sparc: Implement watchdog_nmi_enable and watchdog_nmi_disable Babu Moger
2016-11-04 16:25 ` [PATCH v2 0/3] Clean up watchdog handlers Don Zickus
2016-11-04 16:52 ` Babu Moger
2016-11-21 18:42 ` David Miller
[not found] ` <29fb1134-c709-499a-4176-95e78594a28a@oracle.com>
2016-11-21 20:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478034826-43888-1-git-send-email-babu.moger@oracle.com \
--to=babu.moger@oracle.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=atomlin@redhat.com \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=davem@davemloft.net \
--cc=dzickus@redhat.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=jkosina@suse.cz \
--cc=johunt@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=tj@kernel.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®