From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758676AbcKCQBG (ORCPT ); Thu, 3 Nov 2016 12:01:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9070 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758106AbcKCQBF (ORCPT ); Thu, 3 Nov 2016 12:01:05 -0400 From: Andreas Gruenbacher To: Casey Schaufler , Al Viro Cc: Andreas Gruenbacher , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, Stephen Smalley Subject: Re: [PATCH] xattr: Fix setting security xattrs on sockfs Date: Thu, 3 Nov 2016 17:00:59 +0100 Message-Id: <1478188859-12354-1-git-send-email-agruenba@redhat.com> References: <1478115261-29669-1-git-send-email-agruenba@redhat.com> <57e9db81-d785-98ab-dd52-47c1f82c76c3@schaufler-ca.com> <1478180706-9456-1-git-send-email-agruenba@redhat.com> In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 03 Nov 2016 16:01:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 3, 2016 at 4:51 PM, Casey Schaufler wrote: > On 11/3/2016 6:45 AM, Andreas Gruenbacher wrote: >> Casey, the first patch broke filesystems that support setxattr for some xattrs >> but not security xattrs. Here's an updated patch; could you please test? > > This patch does not fix the problem. I am back to EOPTNOTSUP. Ah, I forgot to register the new sockfs xattr handler. Does this help? Thanks, Andreas --- net/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/socket.c b/net/socket.c index 816392a..9820725 100644 --- a/net/socket.c +++ b/net/socket.c @@ -357,6 +357,7 @@ static const struct xattr_handler sockfs_security_xattr_handler = { static const struct xattr_handler *sockfs_xattr_handlers[] = { &sockfs_xattr_handler, + &sockfs_security_xattr_handler, NULL }; -- 2.7.4