From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933576AbcKDDqL (ORCPT ); Thu, 3 Nov 2016 23:46:11 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:52107 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933253AbcKDDqJ (ORCPT ); Thu, 3 Nov 2016 23:46:09 -0400 X-ME-Sender: X-Sasl-enc: gN8u8K01M0oigqgRqaJqPBeEgrYU+CKi7Uaqb6zQXvFC 1478231166 Message-ID: <1478231157.27396.72.camel@aj.id.au> Subject: Re: [PATCH v2 3/6] mfd: dt: Add bindings for the Aspeed LPC Host Controller (LPCHC) From: Andrew Jeffery To: Joel Stanley Cc: Lee Jones , Linus Walleij , Mark Rutland , Rob Herring , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Fri, 04 Nov 2016 14:15:57 +1030 In-Reply-To: References: <1478097481-14895-1-git-send-email-andrew@aj.id.au> <1478097481-14895-4-git-send-email-andrew@aj.id.au> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-tXmS+8vWBUT1mhXC1E52" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-tXmS+8vWBUT1mhXC1E52 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-11-04 at 09:36 +1030, Joel Stanley wrote: > On Thu, Nov 3, 2016 at 1:07 AM, Andrew Jeffery wrote: > >=20 > > The Aspeed LPC Host Controller is presented as a syscon device to > > arbitrate access by LPC and pinmux drivers. LPC pinmux configuration on > > fifth generation SoCs depends on bits in both the System Control Unit > > and the LPC Host Controller. > >=20 > > Signed-off-by: Andrew Jeffery > > --- > > =C2=A0Documentation/devicetree/bindings/mfd/aspeed-lpchc.txt | 17 +++++= ++++++++++++ > > =C2=A01 file changed, 17 insertions(+) > > =C2=A0create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-l= pchc.txt > >=20 > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpchc.txt b/D= ocumentation/devicetree/bindings/mfd/aspeed-lpchc.txt > > new file mode 100644 > > index 000000000000..792651488c3d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpchc.txt > > @@ -0,0 +1,17 @@ > > +* Device tree bindings for the Aspeed LPC Host Controller (LPCHC) > I had to check the data sheet for that acronym. They call the > registers LHC. I somewhat prefer that name, but if you're happy with > it as-is then that's fine. I had an internal debate about this. I figured LPCHC might give a bit more context to the acronym. I'm not unhappy with it but I wouldn't claim I'm happy either. I will change it to LHC since you somewhat prefer it, and it better aligns with the datasheet. >=20 > I assume this is not an issue on the g4/ast2400? Correct, we don't have the issue of pinmux needing to reach into the LPC IO space on the AST2400. I don't think we've had anything else to drive us to looking at the host controller space there, so I wasn't going to add it to the bindings yet. >=20 > >=20 > > + > > +The LPCHC registers configure LPC behaviour between the BMC and the ho= st > > +system. The LPCHC also participates in pinmux requests on g5 SoCs and = is > > +therefore considered a syscon device. > > + > > +Required properties: > > +- compatible:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0"aspeed,ast2500-lpchc", "syscon" > > +- reg:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0contains offset/length value of the = LPCHC memory > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0region= . > > + > > +Example: > > + > > +lpchc: lpchc@1e7890a0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0compatible =3D "aspeed,ast25= 00-lpchc", "syscon"; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0reg =3D <0x1e7890a0 0xc4>; > Where's the 0xc4 come from? I can see 9 registers, which would mean > the length should be 0x24? Yes, it should be 0x24. I can't even claim that 'c' is near '2'. Thanks for catching that. Andrew >=20 > Cheers, >=20 > Joel --=-tXmS+8vWBUT1mhXC1E52 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJYHAR1AAoJEJ0dnzgO5LT5ERkP/R1u6OEeqrLaQHd2h9UYOQoo q2zD2IICzEYXaM/hs+1zufwvxLOkHNwzL/pU3AydrAKPETc+02PPwflW38ACgu+w CYqnLwn5cRnvjEUUBNPYP1KblgrAWwYUs4QvUBx5R1pBIyu69k+zrCscJRhznxXQ 42Yls860sD4F/KU6umkeTXVcKx3Nx6l0J9RgHV5f05hT2m9TlHGy1U8vjV6d1yPt sPWFYlhP2MbuCN9p5eVAD8P4mB5ZNVGdKetAhk87szXmL1SOgF5B+bGkuy8x1yPd uSLFbWz7YweYVY/Ui+WBLvY1oVqYtCzkn+KBqp9MS2FlaeprI4LSnmFqDyKkq0uB 1zU2wzgeVsHcuDFntvddR5d+R4gA4I7NjXO6wj6PZuRho1ph06hejveS5Qy7ltiG GDp5PFhfvPP0fdu8xOOHxzwI7drgSApFhEIKIQzeiyAg/8U37jsSR8Ll5VjubeX/ hJ6axd6GOp5seAhQFb91mUj25P5FnfmWxBBROn/ajUL9fr+XHMR/vc/ygMXlEFqK W3ipLPnrX50leepfVpHbz4oMOdNH4uDkY6s83p9urfaMaULCgSRj5iPQMi1a8lIB WFd2L8awFytuiqw3uYoXXk7hu0DksOyS6sNgfmuSS0swgUlPrPU9Me6qHikn09Sn zeVNScB+e1pbYrnQ3822 =GVxM -----END PGP SIGNATURE----- --=-tXmS+8vWBUT1mhXC1E52--