mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandre Bailon <abailon@baylibre.com>
To: david@lechnology.com, b-liu@ti.com, balbi@kernel.org
Cc: kishon@ti.com, khilman@baylibre.com,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	nsekhar@ti.com, Alexandre Bailon <abailon@baylibre.com>
Subject: [PATCH v5 2/4] phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround
Date: Mon,  7 Nov 2016 14:05:06 +0100	[thread overview]
Message-ID: <1478523908-4383-3-git-send-email-abailon@baylibre.com> (raw)
In-Reply-To: <1478523908-4383-1-git-send-email-abailon@baylibre.com>

If we configure the da8xx OTG phy in OTG mode, neither device or host
mode will work. That is because the PHY is not able to detect and notify
the driver that value of ID pin changed.
To work despite this hardware limitation, the da8xx glue implement a
workaround.
But to work, the workaround require the VBUS sense and the session end
comparator to enabled.
Enable them if the phy is configured in OTG mode.

Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
---
 drivers/phy/phy-da8xx-usb.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/phy/phy-da8xx-usb.c b/drivers/phy/phy-da8xx-usb.c
index 32ae78c..089c13b 100644
--- a/drivers/phy/phy-da8xx-usb.c
+++ b/drivers/phy/phy-da8xx-usb.c
@@ -23,6 +23,8 @@
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 
+#define PHY_INIT_BITS	(CFGCHIP2_SESENDEN | CFGCHIP2_VBDTCTEN)
+
 struct da8xx_usb_phy {
 	struct phy_provider	*phy_provider;
 	struct phy		*usb11_phy;
@@ -207,6 +209,9 @@ static int da8xx_usb_phy_probe(struct platform_device *pdev)
 			dev_warn(dev, "Failed to create usb20 phy lookup\n");
 	}
 
+	regmap_write_bits(d_phy->regmap, CFGCHIP(2),
+			  PHY_INIT_BITS, PHY_INIT_BITS);
+
 	return 0;
 }
 
-- 
2.7.3

  parent reply	other threads:[~2016-11-07 13:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 13:05 [PATCH v5 0/4] usb: musb: da8xx: Fix few issues Alexandre Bailon
2016-11-07 13:05 ` [PATCH v5 1/4] usb: musb: da8xx: Call earlier clk_prepare_enable() Alexandre Bailon
2016-11-07 13:05 ` Alexandre Bailon [this message]
2016-11-15 13:12   ` [PATCH v5 2/4] phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround Kishon Vijay Abraham I
2016-11-07 13:05 ` [PATCH v5 3/4] usb: musb: Add a new argument to musb_platform_set_mode() Alexandre Bailon
2016-11-14 17:36   ` Bin Liu
2016-11-14 17:37     ` Alexandre Bailon
2016-11-07 13:05 ` [PATCH v5 4/4] usb: musb: da8xx: Set phy in OTG mode by default Alexandre Bailon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478523908-4383-3-git-send-email-abailon@baylibre.com \
    --to=abailon@baylibre.com \
    --cc=b-liu@ti.com \
    --cc=balbi@kernel.org \
    --cc=david@lechnology.com \
    --cc=khilman@baylibre.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®