From: Oliver Neukum <oneukum@suse.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: fix invalid user-pointer checks
Date: Tue, 08 Nov 2016 15:13:13 +0100 [thread overview]
Message-ID: <1478614393.2168.2.camel@suse.com> (raw)
In-Reply-To: <1478608010-23588-1-git-send-email-johan@kernel.org>
On Tue, 2016-11-08 at 13:26 +0100, Johan Hovold wrote:
> Drop invalid user-pointer checks from ioctl handlers.
>
> A NULL-pointer can be valid in user space and copy_to_user() takes
> care
> of sanity checking.
Shouldn't we bail out early in these cases?
Regards
Oliver
next prev parent reply other threads:[~2016-11-08 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 12:26 Johan Hovold
2016-11-08 14:13 ` Oliver Neukum [this message]
2016-11-08 15:41 ` Johan Hovold
2016-11-09 10:58 ` Oliver Neukum
2016-11-09 11:07 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478614393.2168.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome