mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keerthy <j-keerthy@ti.com>
To: <tony@atomide.com>, <lee.jones@linaro.org>, <robh+dt@kernel.org>
Cc: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<nm@ti.com>, <j-keerthy@ti.com>, <t-kristo@ti.com>
Subject: [PATCH v2 3/5] mfd: palmas: Reset the POWERHOLD mux during power off
Date: Thu, 10 Nov 2016 10:39:18 +0530	[thread overview]
Message-ID: <1478754560-27923-4-git-send-email-j-keerthy@ti.com> (raw)
In-Reply-To: <1478754560-27923-1-git-send-email-j-keerthy@ti.com>

POWERHOLD signal has higher priority  over the DEV_ON bit.
So power off will not happen if the POWERHOLD is held high.
Hence reset the MUX to GPIO_7 mode to release the POWERHOLD
and the DEV_ON bit to take effect to power off the PMIC.

PMIC Power off happens in dire situations like thermal shutdown
so irrespective of the POWERHOLD setting go ahead and turn off
the powerhold.  Currently poweroff is broken on boards that have
powerhold enabled. This fixes poweroff on those boards.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---

Changes in v2:

  * Changed pr_err to dev_err
  * removed redundant boolean variable override-powerhold

 drivers/mfd/palmas.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index ee9e9ea..da90124 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -430,6 +430,20 @@ static void palmas_power_off(void)
 {
 	unsigned int addr;
 	int ret, slave;
+	struct device_node *np = palmas_dev->dev->of_node;
+
+	if (of_property_read_bool(np, "ti,palmas-override-powerhold")) {
+		addr = PALMAS_BASE_TO_REG(PALMAS_PU_PD_OD_BASE,
+					  PALMAS_PRIMARY_SECONDARY_PAD2);
+		slave = PALMAS_BASE_TO_SLAVE(PALMAS_PU_PD_OD_BASE);
+
+		ret = regmap_update_bits(palmas_dev->regmap[slave], addr,
+				PALMAS_PRIMARY_SECONDARY_PAD2_GPIO_7_MASK, 0);
+		if (ret)
+			dev_err(palmas_dev->dev,
+				"Unable to write PRIMARY_SECONDARY_PAD2 %d\n",
+				ret);
+	}
 
 	slave = PALMAS_BASE_TO_SLAVE(PALMAS_PMU_CONTROL_BASE);
 	addr = PALMAS_BASE_TO_REG(PALMAS_PMU_CONTROL_BASE, PALMAS_DEV_CTRL);
-- 
1.9.1

  parent reply	other threads:[~2016-11-10  5:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10  5:09 [PATCH v2 0/5] mfd: palmas: add powerhold overriding " Keerthy
2016-11-10  5:09 ` [PATCH v2 1/5] Documentation: pinctrl: palmas: Add ti,palmas-powerhold-override property definition Keerthy
2016-11-15  1:43   ` Rob Herring
2016-11-24  5:28     ` Keerthy
2016-11-24  8:45       ` Lee Jones
2016-11-28  3:51         ` Keerthy
2016-11-10  5:09 ` [PATCH v2 2/5] mfd: palmas: Remove redundant check in palmas_power_off Keerthy
2016-11-22 13:02   ` Lee Jones
2016-11-10  5:09 ` Keerthy [this message]
2016-11-22 13:03   ` [PATCH v2 3/5] mfd: palmas: Reset the POWERHOLD mux during power off Lee Jones
2017-03-24 10:00     ` Keerthy
2017-03-24 11:30       ` Lee Jones
2017-03-24 11:36         ` Keerthy
2016-11-10  5:09 ` [PATCH v2 4/5] arm: dts: am57xx-beagle-x15-common: Add overide powerhold property Keerthy
2016-11-15  0:08   ` Tony Lindgren
2016-11-23  3:35     ` Keerthy
2016-11-23  8:33       ` Lee Jones
2016-11-23  8:32         ` Keerthy
2016-11-23 16:08           ` Tony Lindgren
2016-11-24  3:45             ` Keerthy
2016-11-10  5:09 ` [PATCH v2 5/5] arm: dts: am57xx-idk-common: " Keerthy
2016-11-15  0:09   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478754560-27923-4-git-send-email-j-keerthy@ti.com \
    --to=j-keerthy@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®