From: David Woodhouse <dwmw2@infradead.org>
To: Joerg Roedel <joro@8bytes.org>
Cc: Xunlei Pang <xlpang@redhat.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH] iommu/vt-d: Fix the size calculation of pasid table
Date: Thu, 10 Nov 2016 11:02:52 +0000 [thread overview]
Message-ID: <1478775772.85722.7.camel@infradead.org> (raw)
In-Reply-To: <20161110104544.GA2078@8bytes.org>
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
On Thu, 2016-11-10 at 11:45 +0100, Joerg Roedel wrote:
> Hi David,
>
> On Sun, Oct 30, 2016 at 06:18:22AM -0600, David Woodhouse wrote:
> > + /* Start at 2 because it's defined as 1^(1+PSS) */
>
> This probably means 2^(1+PSS), right?
Or 1 << (1+PSS). Yeah.
> > + iommu->pasid_max = 2 << ecap_pss(iommu->ecap);
>
> Otherwise the patch looks good. Do you want to send it upstream yourself
> or should I pick it up?
I'll let it sit in -next for a day or two more once I've fixed the
above, then ask Linus to pull it. Thanks.
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5760 bytes --]
prev parent reply other threads:[~2016-11-10 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 2:49 Xunlei Pang
2016-09-19 12:18 ` Joerg Roedel
2016-10-10 13:00 ` Xunlei Pang
2016-10-12 12:17 ` David Woodhouse
2016-10-30 12:18 ` David Woodhouse
2016-10-31 11:30 ` Xunlei Pang
2016-11-10 10:45 ` Joerg Roedel
2016-11-10 11:02 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478775772.85722.7.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.kuoppala@linux.intel.com \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®