From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752554AbcKNBhQ (ORCPT ); Sun, 13 Nov 2016 20:37:16 -0500 Received: from mailgw01.mediatek.com ([218.249.47.110]:57672 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752273AbcKNBhM (ORCPT ); Sun, 13 Nov 2016 20:37:12 -0500 Message-ID: <1479087424.6792.20.camel@mhfsdcap03> Subject: Re: [PATCH] usb: mtu3: declare functions static From: Chunfeng Yun To: Sudip Mukherjee CC: Greg Kroah-Hartman , , Date: Mon, 14 Nov 2016 09:37:04 +0800 In-Reply-To: <1479069933-14147-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1479069933-14147-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sun, 2016-11-13 at 20:45 +0000, Sudip Mukherjee wrote: > The only user of the functions mtu3_irq() and gpd_ring_empty() are in > the same file. They can be declared as static. > > Signed-off-by: Sudip Mukherjee > --- > drivers/usb/mtu3/mtu3_core.c | 2 +- > drivers/usb/mtu3/mtu3_qmu.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c > index 520e55a..603b7f84 100644 > --- a/drivers/usb/mtu3/mtu3_core.c > +++ b/drivers/usb/mtu3/mtu3_core.c > @@ -696,7 +696,7 @@ static irqreturn_t mtu3_u2_common_isr(struct mtu3 *mtu) > return IRQ_HANDLED; > } > > -irqreturn_t mtu3_irq(int irq, void *data) > +static irqreturn_t mtu3_irq(int irq, void *data) > { > struct mtu3 *mtu = (struct mtu3 *)data; > unsigned long flags; > diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c > index a6dd292..7d9ba8a 100644 > --- a/drivers/usb/mtu3/mtu3_qmu.c > +++ b/drivers/usb/mtu3/mtu3_qmu.c > @@ -168,7 +168,7 @@ static struct qmu_gpd *advance_deq_gpd(struct mtu3_gpd_ring *ring) > } > > /* check if a ring is emtpy */ > -int gpd_ring_empty(struct mtu3_gpd_ring *ring) > +static int gpd_ring_empty(struct mtu3_gpd_ring *ring) > { > struct qmu_gpd *enq = ring->enqueue; > struct qmu_gpd *next; It's my carelessness. Acked-by: Chunfeng Yun Thanks