mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nayna Jain <nayna@linux.vnet.ibm.com>
To: tpmdd-devel@lists.sourceforge.net
Cc: peterhuewe@gmx.de, tpmdd@selhorst.net,
	jarkko.sakkinen@linux.intel.com, jgunthorpe@obsidianresearch.com,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	Nayna Jain <nayna@linux.vnet.ibm.com>
Subject: [PATCH v6 8/9] tpm: replace of_find_node_by_name() with dev of_node property
Date: Mon, 14 Nov 2016 05:00:55 -0500	[thread overview]
Message-ID: <1479117656-12403-9-git-send-email-nayna@linux.vnet.ibm.com> (raw)
In-Reply-To: <1479117656-12403-1-git-send-email-nayna@linux.vnet.ibm.com>

Using the device of_node property is a better way to refer to the
device tree node rather than of_find_node_by_name().

Suggested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
 drivers/char/tpm/tpm_of.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
index 7c30752..22b8f81 100644
--- a/drivers/char/tpm/tpm_of.c
+++ b/drivers/char/tpm/tpm_of.c
@@ -29,7 +29,8 @@ int read_log_of(struct tpm_chip *chip)
 	struct tpm_bios_log *log;
 
 	log = &chip->log;
-	np = of_find_node_by_name(NULL, "vtpm");
+	if (chip->dev.parent->of_node)
+		np = chip->dev.parent->of_node;
 	if (!np) {
 		pr_err("%s: ERROR - IBMVTPM not supported\n", __func__);
 		return -ENODEV;
@@ -55,18 +56,15 @@ int read_log_of(struct tpm_chip *chip)
 	if (!log->bios_event_log) {
 		pr_err("%s: ERROR - Not enough memory for BIOS measurements\n",
 		       __func__);
-		of_node_put(np);
 		return -ENOMEM;
 	}
 
 	log->bios_event_log_end = log->bios_event_log + *sizep;
 
 	memcpy(log->bios_event_log, __va(*basep), *sizep);
-	of_node_put(np);
 
 	return 0;
 
 cleanup_eio:
-	of_node_put(np);
 	return -EIO;
 }
-- 
2.5.0

  parent reply	other threads:[~2016-11-14 10:01 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 10:00 [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Nayna Jain
2016-11-14 10:00 ` [PATCH v6 1/9] tpm: define a generic open() method for ascii & bios measurements Nayna Jain
2016-11-14 10:00 ` [PATCH v6 2/9] tpm: replace symbolic permission with octal for securityfs files Nayna Jain
2016-11-14 22:18   ` Jarkko Sakkinen
2016-11-14 22:21   ` Jarkko Sakkinen
2016-11-15  0:11     ` [tpmdd-devel] " Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array Nayna Jain
2016-11-22 11:23   ` Jarkko Sakkinen
2016-11-22 16:58     ` Jason Gunthorpe
2016-11-24 13:57       ` Jarkko Sakkinen
2016-11-24 16:53         ` Jason Gunthorpe
2016-11-25  8:08           ` Jarkko Sakkinen
2016-11-25 19:38             ` Jason Gunthorpe
2016-11-26 12:54               ` Jarkko Sakkinen
2016-11-22 19:26     ` Nayna
2016-11-24 14:01       ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister) Nayna Jain
2016-11-22 11:22   ` Jarkko Sakkinen
2016-11-22 16:42     ` Jason Gunthorpe
2016-11-23 18:33       ` Nayna
2016-11-24 11:52         ` Jarkko Sakkinen
2016-11-24 11:51       ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 5/9] tpm: have event log use the tpm_chip Nayna Jain
2016-11-14 23:44   ` Jarkko Sakkinen
2016-11-15  0:12     ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 6/9] tpm: fix the missing .owner in tpm_bios_measurements_ops Nayna Jain
2016-11-14 22:22   ` Jarkko Sakkinen
2016-11-15  0:13     ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 7/9] tpm: redefine read_log() to handle ACPI/OF at runtime Nayna Jain
2016-11-15  0:14   ` Jarkko Sakkinen
2016-11-14 10:00 ` Nayna Jain [this message]
2016-11-14 10:00 ` [PATCH v6 9/9] tpm: cleanup of printk error messages Nayna Jain
2016-11-14 22:24   ` Jarkko Sakkinen
2016-11-15  0:15     ` Jarkko Sakkinen
2016-11-14 22:33 ` [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen
2016-11-15  0:25   ` Jarkko Sakkinen
2016-11-15  0:30     ` Jarkko Sakkinen
2016-11-15  2:15     ` Jarkko Sakkinen
2016-11-15  5:35       ` Nayna
2016-11-15 17:40         ` Jarkko Sakkinen
2016-11-15 18:06           ` Jason Gunthorpe
2016-11-15 18:54             ` Jarkko Sakkinen
2016-11-19 18:36               ` Jason Gunthorpe
2016-11-20  9:58                 ` Jarkko Sakkinen
2016-11-21 18:25                   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479117656-12403-9-git-send-email-nayna@linux.vnet.ibm.com \
    --to=nayna@linux.vnet.ibm.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome