From: William Wu <wulf@rock-chips.com>
To: kishon@ti.com, heiko@sntech.de
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, frank.wang@rock-chips.com,
huangtao@rock-chips.com, dianders@google.com,
briannorris@google.com, groeck@google.com, wulf@rock-chips.com
Subject: [PATCH v4 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time
Date: Tue, 15 Nov 2016 11:54:07 +0800 [thread overview]
Message-ID: <1479182047-3399-3-git-send-email-wulf@rock-chips.com> (raw)
In-Reply-To: <1479182047-3399-1-git-send-email-wulf@rock-chips.com>
We found that the system crashed due to 480MHz output clock of
USB2 PHY was unstable after clock had been enabled by gpu module.
Theoretically, 1 millisecond is a critical value for 480MHz
output clock stable time, so we try to change the delay time
to 1.2 millisecond to avoid this issue.
And the commit ed907fb1d7c3 ("phy: rockchip-inno-usb2: correct
clk_ops callback") used prepare callbacks instead of enable
callbacks to support gate a clk if the operation may sleep. So
we can switch from delay to sleep functions.
Also fix a spelling error from "waitting" to "waiting".
Signed-off-by: William Wu <wulf@rock-chips.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v4:
- add Reviewed-by and fix a spelling error
Changes in v3:
- None
Changes in v2:
- None
drivers/phy/phy-rockchip-inno-usb2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c
index 365e077..5d922fc 100644
--- a/drivers/phy/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/phy-rockchip-inno-usb2.c
@@ -165,8 +165,8 @@ static int rockchip_usb2phy_clk480m_prepare(struct clk_hw *hw)
if (ret)
return ret;
- /* waitting for the clk become stable */
- mdelay(1);
+ /* waiting for the clk become stable */
+ usleep_range(1200, 1300);
}
return 0;
--
2.0.0
next prev parent reply other threads:[~2016-11-15 3:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 3:54 [PATCH v4 0/2] phy: rockchip-inno-usb2: correct 480MHz clk_ops callbacks and " William Wu
2016-11-15 3:54 ` [PATCH v4 1/2] phy: rockchip-inno-usb2: correct clk_ops callback William Wu
2016-11-15 3:54 ` William Wu [this message]
2016-11-15 13:00 ` [PATCH v4 0/2] phy: rockchip-inno-usb2: correct 480MHz clk_ops callbacks and stable time Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479182047-3399-3-git-send-email-wulf@rock-chips.com \
--to=wulf@rock-chips.com \
--cc=briannorris@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=frank.wang@rock-chips.com \
--cc=groeck@google.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®