From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933865AbcKPQKn convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Nov 2016 11:10:43 -0500
Received: from shell.v3.sk ([92.60.52.57]:39609 "EHLO shell.v3.sk"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932184AbcKPQKl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Nov 2016 11:10:41 -0500
Message-ID: <1479312634.14443.2.camel@v3.sk>
Subject: Re: [PATCH] scr24x_cs: include linux/io.h
From: Lubomir Rintel <lkundrak@v3.sk>
To: Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Date: Wed, 16 Nov 2016 17:10:34 +0100
In-Reply-To: <20161116152342.3414667-1-arnd@arndb.de>
References: <20161116152342.3414667-1-arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.1 (3.22.1-2.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-11-16 at 16:23 +0100, Arnd Bergmann wrote:
> The newly added scr24x_cs driver doesn't build in some
> configurations:
> 
> drivers/char/pcmcia/scr24x_cs.c: In function 'scr24x_wait_ready':
> drivers/char/pcmcia/scr24x_cs.c:76:12: error: implicit declaration of
> function 'ioread8' [-Werror=implicit-function-declaration]
> 
> Adding in explicit include for the right header makes it work.
> 
> Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface
> driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/char/pcmcia/scr24x_cs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/pcmcia/scr24x_cs.c
> b/drivers/char/pcmcia/scr24x_cs.c
> index 4f215ce1a3be..a1de354a89a7 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -27,6 +27,7 @@
>  #include <linux/cdev.h>
>  #include <linux/slab.h>
>  #include <linux/fs.h>
> +#include <linux/io.h>
>  #include <linux/uaccess.h>
>  
>  #include <pcmcia/cistpl.h>

Acked-by: Lubomir Rintel <lkundrak@v3.sk>

Thanks