From: Christoph Hellwig <hch@lst.de>
To: mst@redhat.com
Cc: axboe@kernel.dk, virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 11/11] virtio_blk: use virtio IRQ affinity
Date: Thu, 17 Nov 2016 11:43:23 +0100 [thread overview]
Message-ID: <1479379403-27880-12-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1479379403-27880-1-git-send-email-hch@lst.de>
Use automatic IRQ affinity assignment in the virtio layer if available,
and build the blk-mq queues based on it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/block/virtio_blk.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 689e790..7982090 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -5,6 +5,7 @@
#include <linux/hdreg.h>
#include <linux/module.h>
#include <linux/mutex.h>
+#include <linux/interrupt.h>
#include <linux/virtio.h>
#include <linux/virtio_blk.h>
#include <linux/scatterlist.h>
@@ -12,6 +13,7 @@
#include <scsi/scsi_cmnd.h>
#include <linux/idr.h>
#include <linux/blk-mq.h>
+#include <linux/blk-mq-virtio.h>
#include <linux/numa.h>
#define PART_BITS 4
@@ -383,6 +385,7 @@ static int init_vq(struct virtio_blk *vblk)
struct virtqueue **vqs;
unsigned short num_vqs;
struct virtio_device *vdev = vblk->vdev;
+ struct irq_affinity desc = { 0, };
err = virtio_cread_feature(vdev, VIRTIO_BLK_F_MQ,
struct virtio_blk_config, num_queues,
@@ -410,7 +413,7 @@ static int init_vq(struct virtio_blk *vblk)
/* Discover virtqueues and write information to configuration. */
err = vdev->config->find_vqs(vdev, num_vqs, vqs, callbacks, names,
- NULL);
+ &desc);
if (err)
goto out;
@@ -541,10 +544,18 @@ static int virtblk_init_request(void *data, struct request *rq,
return 0;
}
+static int virtblk_map_queues(struct blk_mq_tag_set *set)
+{
+ struct virtio_blk *vblk = set->driver_data;
+
+ return blk_mq_virtio_map_queues(set, vblk->vdev, 0);
+}
+
static struct blk_mq_ops virtio_mq_ops = {
.queue_rq = virtio_queue_rq,
.complete = virtblk_request_done,
.init_request = virtblk_init_request,
+ .map_queues = virtblk_map_queues,
};
static unsigned int virtblk_queue_depth;
--
2.1.4
next prev parent reply other threads:[~2016-11-17 10:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 10:43 automatic IRQ affinity for virtio Christoph Hellwig
2016-11-17 10:43 ` [PATCH 01/11] virtio_pci: use pci_alloc_irq_vectors Christoph Hellwig
2016-11-17 10:43 ` [PATCH 02/11] virtio_pci: remove the call to vp_free_vectors in vp_request_msix_vectors Christoph Hellwig
2016-11-17 10:43 ` [PATCH 03/11] virtio_pci: merge vp_free_vectors into vp_del_vqs Christoph Hellwig
2016-11-17 10:43 ` [PATCH 04/11] virtio_pci: split vp_try_to_find_vqs into INTx and MSI-X variants Christoph Hellwig
2016-11-17 10:43 ` [PATCH 05/11] virtio_pci: use shared interrupts for virtqueues Christoph Hellwig
2016-11-17 10:43 ` [PATCH 06/11] virtio_pci: use msix_enable flag in struct pci_dev Christoph Hellwig
2016-11-17 10:43 ` [PATCH 07/11] virtio_pci: simplify MSI-X setup Christoph Hellwig
2016-11-17 10:43 ` [PATCH 08/11] virtio: allow drivers to request IRQ affinity when creating VQs Christoph Hellwig
2016-11-17 10:43 ` [PATCH 09/11] virtio: provide a method to get the IRQ affinity mask for a virtqueue Christoph Hellwig
2016-11-17 10:43 ` [PATCH 10/11] blk-mq: provide a default queue mapping for virtio device Christoph Hellwig
2016-11-17 10:43 ` Christoph Hellwig [this message]
2016-11-25 7:25 ` automatic IRQ affinity for virtio Christoph Hellwig
2016-11-27 3:37 ` Michael S. Tsirkin
2016-12-07 18:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479379403-27880-12-git-send-email-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®