mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: smohammed@nvidia.com, treding@nvidia.com,
	Michal Marek <mmarek@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: i2c: undefined option I2C_ALGO_BUSCLEAR
Date: Thu, 17 Nov 2016 12:55:15 +0100	[thread overview]
Message-ID: <1479383715.19539.53.camel@tiscali.nl> (raw)
In-Reply-To: <20161117113301.qqce6a4kmmsv6ijl@tumbleweed>

Hi Valentin,

On Thu, 2016-11-17 at 12:33 +0100, Valentin Rothberg wrote:
> I tested your patch and it works properly for me.  It even still applies
> on linux-next.

Cool.

(We should probably compile a list of current invalid selects somewhere
publicly, and team up to submit patches for the low hanging fruit (ie, obvious
typos) and for the arches that actually matter before I resubmit.)

> Would it be possible to extend your patch to also check
> symbols in other statements (depends on, if, etc.)?

No. Depending on an unknown symbol is common and correct. Think
    depends on SOME_OBSCURE_ARM_BOARD

somewhere in drivers. Only arm builds will ever know about the
SOME_OBSCURE_ARM_BOARD symbol.

What could be done is starting any "make *config" target with a treewide pass
over all Kconfig files to collect all valid symbols and so spot typos and
other obviously incorrect. The example that comes to mind is
    depends on SH

that I have spotted a few times in the past years. But this treewide pass will
incur some runtime cost and might not be easy to implement cleanly. Perhaps
we're better of with using your script for that.

Thanks,


Paul Bolle

  reply	other threads:[~2016-11-17 11:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16  7:31 Valentin Rothberg
2016-11-16 15:39 ` Thierry Reding
2016-11-16 15:43   ` Thierry Reding
2016-11-17  8:40     ` Shardar Mohammed
2016-11-17  8:58 ` Paul Bolle
2016-11-17 11:33   ` Valentin Rothberg
2016-11-17 11:55     ` Paul Bolle [this message]
2016-11-17 12:44       ` Valentin Rothberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479383715.19539.53.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=smohammed@nvidia.com \
    --cc=treding@nvidia.com \
    --cc=valentinrothberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®