From: Moritz Fischer <moritz.fischer@ettus.com>
To: linux-kernel@vger.kernel.org
Cc: pantelis.antoniou@konsulko.com, robh+dt@kernel.org,
frowand.list@gmail.com, moritz@pure-entropy.org,
devicetree@vger.kernel.org,
Moritz Fischer <moritz.fischer@ettus.com>
Subject: [PATCH] of: Fix issue where code would fall through to error case.
Date: Thu, 17 Nov 2016 15:25:57 -0800 [thread overview]
Message-ID: <1479425157-6235-1-git-send-email-moritz.fischer@ettus.com> (raw)
No longer fall through into the error case that prints out
an error if no error (err = 0) occurred.
Fixes d9181b20a83(of: Add back an error message, restructured)
Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
---
drivers/of/resolver.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
index 783bd09..785076d 100644
--- a/drivers/of/resolver.c
+++ b/drivers/of/resolver.c
@@ -358,9 +358,13 @@ int of_resolve_phandles(struct device_node *overlay)
err = update_usages_of_a_phandle_reference(overlay, prop, phandle);
if (err)
- break;
+ goto err_out;
}
+ of_node_put(tree_symbols);
+
+ return 0;
+
err_out:
pr_err("overlay phandle fixup failed: %d\n", err);
out:
--
2.7.4
next reply other threads:[~2016-11-17 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 23:25 Moritz Fischer [this message]
2016-11-17 23:40 ` Frank Rowand
2016-11-18 0:02 ` Frank Rowand
2016-11-18 0:10 ` Moritz Fischer
2016-11-23 21:58 ` Rob Herring
2016-11-26 21:39 ` Frank Rowand
2016-11-28 15:30 ` Frank Rowand
2016-11-29 15:06 ` Rob Herring
2016-11-29 15:55 ` Moritz Fischer
2016-11-29 16:52 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479425157-6235-1-git-send-email-moritz.fischer@ettus.com \
--to=moritz.fischer@ettus.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moritz@pure-entropy.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome