From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758500Ab3KIBS2 (ORCPT ); Fri, 8 Nov 2013 20:18:28 -0500 Received: from hydra.sisk.pl ([212.160.235.94]:42020 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758008Ab3KIBS1 (ORCPT ); Fri, 8 Nov 2013 20:18:27 -0500 From: "Rafael J. Wysocki" To: Santosh Shilimkar Cc: tj@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Yinghai Lu , Andrew Morton , Pavel Machek , linux-pm@vger.kernel.org Subject: Re: [PATCH 13/24] mm/power: Use memblock apis for early memory allocations Date: Sat, 09 Nov 2013 02:30:44 +0100 Message-ID: <1479529.EjZ9YN8f8I@vostro.rjw.lan> User-Agent: KMail/4.10.5 (Linux/3.12.0-rc6+; KDE/4.10.5; x86_64; ; ) In-Reply-To: <1383954120-24368-14-git-send-email-santosh.shilimkar@ti.com> References: <1383954120-24368-1-git-send-email-santosh.shilimkar@ti.com> <1383954120-24368-14-git-send-email-santosh.shilimkar@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, November 08, 2013 06:41:49 PM Santosh Shilimkar wrote: > Switch to memblock interfaces for early memory allocator instead of > bootmem allocator. No functional change in beahvior than what it is > in current code from bootmem users points of view. > > Archs already converted to NO_BOOTMEM now directly use memblock > interfaces instead of bootmem wrappers build on top of memblock. And the > archs which still uses bootmem, these new apis just fallback to exiting > bootmem APIs. > > Cc: Yinghai Lu > Cc: Tejun Heo > Cc: Andrew Morton > Cc: Pavel Machek > Cc: "Rafael J. Wysocki" > Cc: linux-pm@vger.kernel.org > > Signed-off-by: Santosh Shilimkar Fine by me, thanks! > --- > kernel/power/snapshot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c > index 358a146..887134e 100644 > --- a/kernel/power/snapshot.c > +++ b/kernel/power/snapshot.c > @@ -637,7 +637,7 @@ __register_nosave_region(unsigned long start_pfn, unsigned long end_pfn, > BUG_ON(!region); > } else > /* This allocation cannot fail */ > - region = alloc_bootmem(sizeof(struct nosave_region)); > + region = memblock_virt_alloc(sizeof(struct nosave_region)); > region->start_pfn = start_pfn; > region->end_pfn = end_pfn; > list_add_tail(®ion->list, &nosave_regions); > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.