From: Joe Perches <joe@perches.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Colin King <colin.king@canonical.com>,
David Woodhouse <dwmw2@infradead.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"
Date: Tue, 22 Nov 2016 13:32:27 -0800 [thread overview]
Message-ID: <1479850347.1942.24.camel@perches.com> (raw)
In-Reply-To: <20161122193753.GG77253@google.com>
On Tue, 2016-11-22 at 11:37 -0800, Brian Norris wrote:
> On Fri, Oct 28, 2016 at 11:51:47AM -0700, Joe Perches wrote:
> > I'd suggest as well fixing all the dev_<level> uses
> > to be a consistent form: (this also fixes the typo)
> > and a few other bits
> >
> > o Coalesce formats
> > o Realign arguments
> > o Add missing newlines
>
> Yeah, Colin missed this on the line he was fixing.
>
> > o Convert printk(KERN_<LEVEL> to pr_<level>(
> > o Add #define pr_fmt, remove MTDSWAP_PREFIX
> >
> > Reduces object size a little too
>
> Thanks, these all look good but:
>
> (a) you didn't provide a Signed-off-by and
> (b) your patch is full of non-breaking spaces (0xA0), instead of proper
> ASCII spaces (0x20)
>
> I feel like we've had this conversation before about your Evolution
> mailer a long time ago; you still haven't fixed that?
>
> I'm sorry, but I just can't take your patch. I'm not going to hand-edit
> this one...
No worries, it was an unsigned patch suggestion, not
a formal patch. I know the difference.
And have you ever looked at the evolution source code?
At best, it's pretty convoluted.
There's _no way_ I want to touch it.
next prev parent reply other threads:[~2016-11-22 21:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 18:25 Colin King
2016-10-28 18:51 ` Joe Perches
2016-11-22 19:37 ` Brian Norris
2016-11-22 21:32 ` Joe Perches [this message]
2016-11-22 22:46 ` Brian Norris
2016-11-22 19:49 ` Brian Norris
2016-10-28 18:35 Colin King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479850347.1942.24.camel@perches.com \
--to=joe@perches.com \
--cc=boris.brezillon@free-electrons.com \
--cc=colin.king@canonical.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome