From: kan.liang@intel.com
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
linux-kernel@vger.kernel.org
Cc: alexander.shishkin@linux.intel.com, tglx@linutronix.de,
namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
wangnan0@huawei.com, mark.rutland@arm.com, andi@firstfloor.org,
Kan Liang <kan.liang@intel.com>
Subject: [PATCH 06/14] perf tools: show NMI overhead
Date: Wed, 23 Nov 2016 04:44:44 -0500 [thread overview]
Message-ID: <1479894292-16277-7-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1479894292-16277-1-git-send-email-kan.liang@intel.com>
From: Kan Liang <kan.liang@intel.com>
Caculate the total NMI overhead on each CPU, and display them in perf
report
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
tools/perf/builtin-report.c | 11 +++++++++++
tools/perf/util/event.h | 4 ++++
tools/perf/util/machine.c | 9 +++++++++
tools/perf/util/session.c | 18 ++++++++++++++++++
4 files changed, 42 insertions(+)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 1416c39..b1437586 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -365,11 +365,22 @@ static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist,
struct report *rep,
const char *help)
{
+ struct perf_session *session = rep->session;
struct perf_evsel *pos;
+ int cpu;
fprintf(stdout, "#\n# Total Lost Samples: %" PRIu64 "\n#\n", evlist->stats.total_lost_samples);
if (symbol_conf.show_overhead) {
fprintf(stdout, "# Overhead:\n");
+ for (cpu = 0; cpu < session->header.env.nr_cpus_online; cpu++) {
+ if (!evlist->stats.total_nmi_overhead[cpu][0])
+ continue;
+ if (rep->cpu_list && !test_bit(cpu, rep->cpu_bitmap))
+ continue;
+ fprintf(stdout, "#\tCPU %d: NMI#: %" PRIu64 " time: %" PRIu64 " ns\n",
+ cpu, evlist->stats.total_nmi_overhead[cpu][0],
+ evlist->stats.total_nmi_overhead[cpu][1]);
+ }
fprintf(stdout, "#\n");
}
evlist__for_each_entry(evlist, pos) {
diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
index d1b179b..7d40d54 100644
--- a/tools/perf/util/event.h
+++ b/tools/perf/util/event.h
@@ -262,6 +262,9 @@ enum auxtrace_error_type {
* multipling nr_events[PERF_EVENT_SAMPLE] by a frequency isn't possible to get
* the total number of low level events, it is necessary to to sum all struct
* sample_event.period and stash the result in total_period.
+ *
+ * The total_nmi_overhead tells exactly the NMI handler overhead on each CPU.
+ * The total NMI# is stored in [0], while the accumulated time is in [1].
*/
struct events_stats {
u64 total_period;
@@ -270,6 +273,7 @@ struct events_stats {
u64 total_lost_samples;
u64 total_aux_lost;
u64 total_invalid_chains;
+ u64 total_nmi_overhead[MAX_NR_CPUS][2];
u32 nr_events[PERF_RECORD_HEADER_MAX];
u32 nr_non_filtered_samples;
u32 nr_lost_warned;
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index 1101757..58076f2 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -558,6 +558,15 @@ int machine__process_switch_event(struct machine *machine __maybe_unused,
int machine__process_overhead_event(struct machine *machine __maybe_unused,
union perf_event *event __maybe_unused)
{
+ if (event->overhead.type == PERF_NMI_OVERHEAD) {
+ dump_printf(" NMI nr: %llu time: %llu cpu %u\n",
+ event->overhead.entry.nr,
+ event->overhead.entry.time,
+ event->overhead.entry.cpu);
+ } else {
+ dump_printf("\tUNSUPPORT OVERHEAD TYPE 0x%x!\n", event->overhead.type);
+ }
+
return 0;
}
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index bc0bc21..a79ab99 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1207,6 +1207,23 @@ static int
&sample->read.one, machine);
}
+static void
+overhead_stats_update(struct perf_tool *tool,
+ struct perf_evlist *evlist,
+ union perf_event *event)
+{
+ if (tool->overhead == perf_event__process_overhead) {
+ switch (event->overhead.type) {
+ case PERF_NMI_OVERHEAD:
+ evlist->stats.total_nmi_overhead[event->overhead.entry.cpu][0] += event->overhead.entry.nr;
+ evlist->stats.total_nmi_overhead[event->overhead.entry.cpu][1] += event->overhead.entry.time;
+ break;
+ default:
+ break;
+ }
+ }
+}
+
static int machines__deliver_event(struct machines *machines,
struct perf_evlist *evlist,
union perf_event *event,
@@ -1271,6 +1288,7 @@ static int machines__deliver_event(struct machines *machines,
case PERF_RECORD_SWITCH_CPU_WIDE:
return tool->context_switch(tool, event, sample, machine);
case PERF_RECORD_OVERHEAD:
+ overhead_stats_update(tool, evlist, event);
return tool->overhead(tool, event, sample, machine);
default:
++evlist->stats.nr_unknown_events;
--
2.5.5
next prev parent reply other threads:[~2016-11-23 17:47 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 9:44 [PATCH 00/14] export perf overheads information kan.liang
2016-11-23 9:44 ` [PATCH 01/14] perf/x86: Introduce PERF_RECORD_OVERHEAD kan.liang
2016-11-23 20:11 ` Peter Zijlstra
2016-11-23 20:13 ` Peter Zijlstra
2016-11-23 23:41 ` Jiri Olsa
2016-11-24 13:45 ` Liang, Kan
2016-11-24 13:50 ` Peter Zijlstra
2016-11-24 13:56 ` Liang, Kan
2016-11-24 14:27 ` Jiri Olsa
2016-11-24 14:39 ` Liang, Kan
2016-11-24 14:47 ` Jiri Olsa
2016-11-24 18:28 ` Andi Kleen
2016-11-24 18:58 ` Peter Zijlstra
2016-11-24 19:02 ` Andi Kleen
2016-11-24 19:08 ` Peter Zijlstra
2016-11-23 9:44 ` [PATCH 02/14] perf/x86: output NMI overhead kan.liang
2016-11-23 20:06 ` Peter Zijlstra
2016-11-24 16:19 ` Mark Rutland
2016-11-24 19:02 ` Peter Zijlstra
2016-11-24 19:40 ` Liang, Kan
2016-11-24 23:26 ` Namhyung Kim
2016-11-23 9:44 ` [PATCH 03/14] perf/x86: output multiplexing overhead kan.liang
2016-11-23 20:06 ` Peter Zijlstra
2016-11-23 20:09 ` Liang, Kan
2016-11-23 9:44 ` [PATCH 04/14] perf/x86: output side-band events overhead kan.liang
2016-11-23 20:06 ` Peter Zijlstra
2016-11-24 16:21 ` Mark Rutland
2016-11-24 19:40 ` Liang, Kan
2016-11-23 9:44 ` [PATCH 05/14] perf tools: handle PERF_RECORD_OVERHEAD record type kan.liang
2016-11-23 22:35 ` Jiri Olsa
2016-11-23 22:58 ` Jiri Olsa
2016-11-23 9:44 ` kan.liang [this message]
2016-11-23 22:51 ` [PATCH 06/14] perf tools: show NMI overhead Jiri Olsa
2016-11-24 13:37 ` Liang, Kan
2016-11-24 15:27 ` Jiri Olsa
2016-11-24 23:20 ` Namhyung Kim
2016-11-24 23:45 ` Jiri Olsa
2016-11-25 0:21 ` Andi Kleen
2016-11-23 22:52 ` Jiri Olsa
2016-11-23 22:52 ` Jiri Olsa
2016-11-23 9:44 ` [PATCH 07/14] perf tools: show multiplexing overhead kan.liang
2016-11-23 9:44 ` [PATCH 08/14] perf tools: show side-band events overhead kan.liang
2016-11-23 9:44 ` [PATCH 09/14] perf tools: make get_nsecs visible for buildin files kan.liang
2016-11-23 9:44 ` [PATCH 10/14] perf tools: introduce PERF_RECORD_USER_OVERHEAD kan.liang
2016-11-23 9:44 ` [PATCH 11/14] perf tools: record write data overhead kan.liang
2016-11-23 23:02 ` Jiri Olsa
2016-11-23 23:06 ` Jiri Olsa
2016-11-23 9:44 ` [PATCH 12/14] perf tools: record elapsed time kan.liang
2016-11-23 9:44 ` [PATCH 13/14] perf tools: warn on high overhead kan.liang
2016-11-23 20:25 ` Andi Kleen
2016-11-23 22:03 ` Liang, Kan
2016-11-25 20:42 ` Andi Kleen
2016-11-23 9:44 ` [PATCH 14/14] perf script: show overhead events kan.liang
2016-11-23 23:17 ` Jiri Olsa
2016-11-23 23:18 ` Jiri Olsa
2016-11-23 23:19 ` Jiri Olsa
2016-11-23 23:22 ` Jiri Olsa
2016-11-24 4:27 ` [PATCH 00/14] export perf overheads information Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479894292-16277-7-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome