From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A24C8372B3D for ; Tue, 26 May 2026 07:16:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779779796; cv=none; b=diRWrrab2RvZLyFdy/a+8wkO5O51ezmZCmRIGbu6l5QvrAZn/SdCKIc+yrmzo2JyaipItWqVB/0RTSe5JQXrphdtYuP/p4WMVaRljv+4czXLBxj9pDR9AqgmEUErxZqgy4FN2yfDSroyHWlpxLjV39Yf7KlByf14AwlmODFOOEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779779796; c=relaxed/simple; bh=m4+IQOo0EGMHhlaHDqYgTldeZO4rGpI+3vfP+VqwAgU=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=nF2vip2xgqZ8N15q5FsY8ZHs4mZn0krLMgeCUWQD4TFScKLP5fe9+4Cd6v3X2R2FI/2obedWGq3KhhK3nifnuavlS3rZTOoJSf2+GaZr17ErXNjJJjevIE8WIVx6GiBVbML3B2UP7vSNNSWOdPRTi9W7fi7yjgBkMxgt4sza5TY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lCbTSlD3; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lCbTSlD3" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso87457085e9.2 for ; Tue, 26 May 2026 00:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779779793; x=1780384593; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=6qT/bMdEBMK/k6bRtXEjwywoU6w4KQoZt190nLYNxOs=; b=lCbTSlD3hOd/qg2Ihto9HlrGI+fN426xP13mohXiDfpFqJdGTBfxwYgY9lxCeUTqKn HS3WGwK6I5cuVWBZZoqNTS1qMm5zhWaqxdR1NbvR78JyGpuYkFkLbQOSeWyxRWN0J8oC 4ah4sTsCfdJn1fkLqxVoxM5vnc4Apq1a6V/DJKU4RzlGk99Ay69F43NAO+HZfseY93cs BvIi05JZ4g8k0y7RQWJYP+naKTHtgUMNdsVOh9PpMeYhQNQPcZlXW5Z8cgGyhcF/FIQm QGPwLu1NpC+yHR1S608HwHsgre6/HHXckZpvC+iWyIp/c9XEjr9rcmIEq57JccIugIh3 TMGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779779793; x=1780384593; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6qT/bMdEBMK/k6bRtXEjwywoU6w4KQoZt190nLYNxOs=; b=K35+bZnd8FmUDCOYZqh4Tl6P+HYuX04B3x0+iLo/NsRQjWhZIc2McvE+BD71jJuiE3 Y3X3kMl9teDNY7hfJrR6za0cGxJGFoKifVkU8NgQveLMTdMgROt26zwW1aJqMa8Bmd1W KYyWXfyjLk875roc3U3QdJ/Xe6HkDKWW84SuKv4LSwDu3RGYlSf5YSaqIVvxG+JlD7u4 m3UVWK+bB5CaZ3ZrFsCSzjtE3s1EQRwU0Ct5y3fGO8MRrBMneOmgEeolyhBFM1eakXko kdQpvI9PNYLe5oRqphs7EnZIRmQMp36vAd9qjMaKg9LySZcA/HBHXwdCjHX9YLn51Wrg Gtdg== X-Forwarded-Encrypted: i=1; AFNElJ8M4M7GcB4HsV6dos/PNQ0wgVGgOcKRA8EOdMr1teqtEBhPFT0/INFMa4WphYANRCvcrBv928zYb8pRNJg=@vger.kernel.org X-Gm-Message-State: AOJu0YxSQXun4BL/KvhT5l2f0dYT7K6UyaN0zjB860KguliPpskJqlvR 3VIN6MeC4VkyDbjShPFVfvwKy+YoCZCzZwUYl9S1KDdaAniGNKuTk6eKkPllzeGup8I= X-Gm-Gg: Acq92OEoKewzcKzZywYpOXLkTs6t43O9a2arIzZjZVBWRRc0ftoBGo5UxTtc3SHpEXZ ZI7qKBoblwmnPw418FqQvNOpVAZmQtSiVdziJNIh3gDyK2yfQz1jdDWi1wDJLAf1Xy2m0RWjcY1 pKebfF+d1kjT0Q98kYvZT7Ug2vqMy+4s0Ra7fgoh8cTMSeJLfKIBR7jod92rlFcBz3D3UApsIj7 YJyr44PtibK35r0IYnanLbt7nSRVkvcw7jbTfsBzOWDW1b96C6mokzLDw3fB5ScM4bBKIqZarUk 0D8oRcTNlhzXXDInjaBA56Mqv2OfqiT38ETU8I0jgIfbm9uX1ouNMRTU3mTbDR5ViD6b1xtS+kg lTAhuQL+eiQoLcoCgPmU5Qow3txap4ApoZwy67pGbjpBe2H1HgiM/+ehj5C2lJE7aYqGH28IdsA 6TBfGpTksKgHxLEKvvzXSKj4AGKo000g8YrJsEJf6n2zw1T+Uto5iSTcQk4VfnGt6gv8CkardFU 3kz7d18Y1OhqMKMng== X-Received: by 2002:a05:600c:4591:b0:490:6869:46c6 with SMTP id 5b1f17b1804b1-490686947a8mr90737495e9.31.1779779792774; Tue, 26 May 2026 00:16:32 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:aba9:2be3:1465:636a? ([2a01:e0a:106d:1080:aba9:2be3:1465:636a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904526ca21sm299610585e9.3.2026.05.26.00.16.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 00:16:32 -0700 (PDT) Message-ID: <147bb128-a77c-49e4-897d-ba6ee1b1449d@linaro.org> Date: Tue, 26 May 2026 09:16:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH] drm/meson: clean up KMS polling on register failure To: Myeonghun Pak Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ijae Kim References: <20260524160657.17802-1-mhun512@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260524160657.17802-1-mhun512@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/24/26 18:01, Myeonghun Pak wrote: > meson_drv_bind_master() starts the KMS polling helper before registering > the DRM device. If drm_dev_register() fails, probe unwinds the IRQ and > DRM device without stopping the polling helper. > > Call drm_kms_helper_poll_fini() on that failure path before freeing the > IRQ. > > This issue was identified during our ongoing static-analysis research while > reviewing kernel code. > > Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller") > Cc: stable@vger.kernel.org > Co-developed-by: Ijae Kim > Signed-off-by: Ijae Kim > Signed-off-by: Myeonghun Pak > --- > drivers/gpu/drm/meson/meson_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c > index 49ff9f1f16..e49de5df73 100644 > --- a/drivers/gpu/drm/meson/meson_drv.c > +++ b/drivers/gpu/drm/meson/meson_drv.c > @@ -352,12 +352,14 @@ static int meson_drv_bind_master(struct device *dev, bool has_components) > > ret = drm_dev_register(drm, 0); > if (ret) > - goto uninstall_irq; > + goto uninstall_poll; > > drm_client_setup(drm, NULL); > > return 0; > > +uninstall_poll: > + drm_kms_helper_poll_fini(drm); > uninstall_irq: > free_irq(priv->vsync_irq, drm); > exit_afbcd: Reviewed-by: Neil Armstrong Thanks, Neil