From: Joe Perches <joe@perches.com>
To: jongman.heo@samsung.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: mptbase: fix printk output using pr_cont
Date: Fri, 25 Nov 2016 03:34:24 -0800 [thread overview]
Message-ID: <1480073664.19726.22.camel@perches.com> (raw)
In-Reply-To: <20161125010241epcms1p7e0f70a92e15d61ec80ef4112f81d16cc@epcms1p7>
On Fri, 2016-11-25 at 01:02 +0000, Jongman Heo wrote:
> With current linus git, Fusion MPT driver prints out unnecessary new lines.
>
> [ 2.090255] Fusion MPT base driver 3.04.20
> [ 2.090257] Copyright (c) 1999-2008 LSI Corporation
> [ 2.090262] Fusion MPT SPI Host driver 3.04.20
> [ 2.090979] mptbase: ioc0: Initiating bringup
> [ 2.196306] ioc0:
> [ 2.196310] LSI53C1030 B0:
> [ 2.196312] Capabilities={
> [ 2.196313] Initiator
> [ 2.196314] }
>
>
> I modified set of printk()s to pr_cont to fix the problem.
> Not sure if it's correct, but now I can see the message as previous.
[]
> diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
[]
> @@ -2866,23 +2866,23 @@ MptDisplayIocCapabilities(MPT_ADAPTER *ioc)
> {
> int i = 0;
>
> - printk(KERN_INFO "%s: ", ioc->name);
> + pr_cont(KERN_INFO "%s: ", ioc->name);
This is not s correct conversion.
This can either stay as printk(KERN_INFO
or be converted to pr_info
pr_info("%s: ", ioc->name);
prev parent reply other threads:[~2016-11-25 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161125010241epcms1p7e0f70a92e15d61ec80ef4112f81d16cc@epcms1p7>
2016-11-25 1:02 ` Jongman Heo
2016-11-25 11:34 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480073664.19726.22.camel@perches.com \
--to=joe@perches.com \
--cc=jongman.heo@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®