From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Jiri Kosina <jikos@kernel.org>,
Dennis Chen <barracks510@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bastien Nocera <hadess@hadess.net>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] Support multitouch touchpads in Surface TypeCover
Date: Fri, 25 Nov 2016 14:27:20 +0100 [thread overview]
Message-ID: <1480080443-7636-1-git-send-email-benjamin.tissoires@redhat.com> (raw)
Hi,
this is mostly a resubmission of v1, with one patch exchanged.
The latest investigations by Dennis Chen showed that the first patch did
not changed the internal HID device quirk. So I think the first patch is
still valid for upstream.
Patch 2/3 "HID: multitouch: do not retrieve all reports for all devices" is
an attempt to pro-actively fix the other issues of the TypeCover. It looks
like the quirk HID_QUIRK_NO_INIT_REPORTS was dropped somewhere, but the quirks
set in hid-multitouch were kept. After further thoughts, I think we should
simply mimic the Windows driver and only retrieve the features we actually need.
With this patch, we don't need to add a special case for the Surface 3
cover, the default class just works.
Cheers,
Benjamin
Benjamin Tissoires (3):
HID: input: rework HID_QUIRK_MULTI_INPUT
HID: multitouch: do not retrieve all reports for all devices
HID: multitouch: enable the Surface 3 Type Cover to report multitouch
data
drivers/hid/hid-core.c | 2 -
drivers/hid/hid-ids.h | 1 -
drivers/hid/hid-input.c | 95 +++++++++++++++++++++++------------------
drivers/hid/hid-microsoft.c | 2 -
drivers/hid/hid-multitouch.c | 80 ++++++++++++++++++----------------
drivers/hid/usbhid/hid-quirks.c | 1 -
include/linux/hid.h | 1 +
7 files changed, 98 insertions(+), 84 deletions(-)
--
2.7.4
next reply other threads:[~2016-11-25 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 13:27 Benjamin Tissoires [this message]
2016-11-25 13:27 ` [PATCH v2 1/3] HID: input: rework HID_QUIRK_MULTI_INPUT Benjamin Tissoires
2016-11-25 13:27 ` [PATCH v2 2/3] HID: multitouch: do not retrieve all reports for all devices Benjamin Tissoires
2016-11-25 13:27 ` [PATCH v2 3/3] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data Benjamin Tissoires
2016-11-28 13:41 ` [PATCH v2 0/3] Support multitouch touchpads in Surface TypeCover Jiri Kosina
2016-11-28 13:55 ` Benjamin Tissoires
2016-11-28 13:58 ` Jiri Kosina
2016-11-28 14:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480080443-7636-1-git-send-email-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=barracks510@gmail.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®