From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755786AbcKYTg3 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 25 Nov 2016 14:36:29 -0500
Received: from smtprelay0045.hostedemail.com ([216.40.44.45]:51108 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1755235AbcKYTgV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Nov 2016 14:36:21 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3872:4321:5007:10004:10400:10848:11026:11232:11658:11914:12296:12740:12760:13069:13161:13229:13311:13357:13439:14659:14721:21080:21220:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: anger31_51b67e2ed8856
X-Filterd-Recvd-Size: 1719
Message-ID: <1480102557.19726.33.camel@perches.com>
Subject: Re: [PATCH 1/2] stacktrace: fix print_stack_trace printing
 timestamp twice
From: Joe Perches <joe@perches.com>
To: Dmitry Vyukov <dvyukov@google.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andrey Konovalov <andreyknvl@google.com>,
        Alexander Potapenko <glider@google.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Kostya Serebryany <kcc@google.com>,
        Peter Zijlstra <peterz@infradead.org>
Date: Fri, 25 Nov 2016 11:35:57 -0800
In-Reply-To: <CACT4Y+YB1QBzzdBbPWrq6u2M3B7WuavHZn6KswJi0Qi2DhqDLA@mail.gmail.com>
References: <cover.1478632698.git.andreyknvl@google.com>
         <9df5bd889e1b980d84aa41e7010e622005fd0665.1478632698.git.andreyknvl@google.com>
         <2a6c133d-a42e-34ca-108c-b1399b939d65@virtuozzo.com>
         <CACT4Y+YB1QBzzdBbPWrq6u2M3B7WuavHZn6KswJi0Qi2DhqDLA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.1-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-11-25 at 18:40 +0100, Dmitry Vyukov wrote:
> But should we add KERN_CONT to print_ip_sym instead of duplicating it
> everywhere? Or add print_ip_sym_cont?

There are only a couple dozen uses of print_ip_sym.

It might be better to use "[<%p>] %pS" directly
everywhere and remove print_ip_sym instead to
avoid the KERN_CONT and avoid all possible
interleaved output.