From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758049AbcK2PZ2 (ORCPT ); Tue, 29 Nov 2016 10:25:28 -0500 Received: from faui40.informatik.uni-erlangen.de ([131.188.34.40]:57055 "EHLO faui40.informatik.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757672AbcK2PZP (ORCPT ); Tue, 29 Nov 2016 10:25:15 -0500 X-Greylist: delayed 354 seconds by postgrey-1.27 at vger.kernel.org; Tue, 29 Nov 2016 10:25:14 EST From: Sebastian Duda Cc: linux-kernel@i4.cs.fau.de, Sebastian Duda , Tobias Baumeister , Andrew Morton , Petr Mladek , Sergey Senozhatsky , Borislav Petkov , Tejun Heo , Thierry Reding , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] printk.c: removed unnecessary code Date: Tue, 29 Nov 2016 16:19:01 +0100 Message-Id: <1480432743-8049-1-git-send-email-sebastian.duda@fau.de> X-Mailer: git-send-email 2.7.4 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org snprintf((char *) ?, 0, ...); always returns Zero and doesn't change the data. Thus the execution of snprintf(NULL, 0, "[%5lu.000000] ", (unsigned long)ts); has no effect on program. The substitution with 0 increases the readability of the code. Signed-off-by: Sebastian Duda Signed-off-by: Tobias Baumeister --- kernel/printk/printk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 5028f4f..fe3fec1 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -1186,7 +1186,7 @@ static size_t print_time(u64 ts, char *buf) rem_nsec = do_div(ts, 1000000000); if (!buf) - return snprintf(NULL, 0, "[%5lu.000000] ", (unsigned long)ts); + return 0; return sprintf(buf, "[%5lu.%06lu] ", (unsigned long)ts, rem_nsec / 1000); -- 2.7.4