From: Miklos Szeredi <mszeredi@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/8] overlayfs: fix ro/rw fd data inconsistecies
Date: Thu, 1 Dec 2016 11:14:55 +0100 [thread overview]
Message-ID: <1480587303-25088-1-git-send-email-mszeredi@redhat.com> (raw)
Hi Al,
I'd like to hear your opinion on this patchset before queuing up for 4.10.
Here's the problem:
A file is opened for read-only, opened read-write (resulting in a copy up)
and modified. The data read back from the the read-only fd will be stale
in this case (the read-only file descriptor still refers to the lower,
unmodified file).
This patchset fixes issues related to this corner case.
The VFS impact is minimal and performance in the non-corner cases shouldn't
suffer.
Git tree is here:
git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git #overlayfs-rorw
Pathset is against #overlayfs-next.
Thanks,
Miklos
---
Miklos Szeredi (8):
vfs: allow overlayfs to intercept file ops
vfs: export filp_clone_open()
mm: ovl: copy-up on MAP_SHARED
ovl: add infrastructure for intercepting file ops
ovl: intercept read_iter
ovl: intercept mmap
ovl: intercept fsync
Revert "ovl: Warn on copy up if a process has a R/O fd open to the
lower file"
fs/internal.h | 1 -
fs/open.c | 2 +-
fs/overlayfs/copy_up.c | 34 -------
fs/overlayfs/inode.c | 227 +++++++++++++++++++++++++++++++++++++++++++++++
fs/overlayfs/overlayfs.h | 2 +
fs/overlayfs/super.c | 1 +
include/linux/fs.h | 1 +
mm/util.c | 22 +++++
8 files changed, 254 insertions(+), 36 deletions(-)
--
2.5.5
next reply other threads:[~2016-12-01 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 10:14 Miklos Szeredi [this message]
2016-12-01 10:14 ` [PATCH 1/8] vfs: allow overlayfs to intercept file ops Miklos Szeredi
2016-12-01 10:14 ` [PATCH 2/8] vfs: export filp_clone_open() Miklos Szeredi
2016-12-01 10:14 ` [PATCH 3/8] mm: ovl: copy-up on MAP_SHARED Miklos Szeredi
2016-12-01 10:14 ` [PATCH 4/8] ovl: add infrastructure for intercepting file ops Miklos Szeredi
2016-12-01 10:15 ` [PATCH 5/8] ovl: intercept read_iter Miklos Szeredi
2016-12-01 10:15 ` [PATCH 6/8] ovl: intercept mmap Miklos Szeredi
2016-12-01 10:15 ` [PATCH 7/8] ovl: intercept fsync Miklos Szeredi
2016-12-01 10:15 ` [PATCH 8/8] Revert "ovl: Warn on copy up if a process has a R/O fd open to the lower file" Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480587303-25088-1-git-send-email-mszeredi@redhat.com \
--to=mszeredi@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®