From: Matt Ranostay <matt@ranostay.consulting>
To: linux-kernel@vger.kernel.org
Cc: Matt Ranostay <matt@ranostay.consulting>,
Arnd Bergmann <arnd@arndb.de>, Drew Fustini <pdp7pdp7@gmail.com>
Subject: [PATCH RESEND] tsl2550: fix lux1_input error in low light
Date: Fri, 2 Dec 2016 12:36:41 -0800 [thread overview]
Message-ID: <1480711001-31832-1-git-send-email-matt@ranostay.consulting> (raw)
ADC channel 0 photodiode detects both infrared + visible light,
but ADC channel 1 just detects infrared. However, the latter is a bit
more sensitive in that range so complete darkness or low light causes
a error condition in which the chan0 - chan1 is negative that
results in a -EAGAIN.
This patch changes the resulting lux1_input sysfs attribute message from
"Resource temporarily unavailable" to a user-grokable lux value of 0.
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Drew Fustini <pdp7pdp7@gmail.com>
Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
---
drivers/misc/tsl2550.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c
index 87a13374fdc0..eb5761067310 100644
--- a/drivers/misc/tsl2550.c
+++ b/drivers/misc/tsl2550.c
@@ -177,7 +177,7 @@ static int tsl2550_calculate_lux(u8 ch0, u8 ch1)
} else
lux = 0;
else
- return -EAGAIN;
+ return 0;
/* LUX range check */
return lux > TSL2550_MAX_LUX ? TSL2550_MAX_LUX : lux;
--
2.7.4
reply other threads:[~2016-12-02 20:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480711001-31832-1-git-send-email-matt@ranostay.consulting \
--to=matt@ranostay.consulting \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pdp7pdp7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®