From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752437AbcLDGI3 (ORCPT ); Sun, 4 Dec 2016 01:08:29 -0500 Received: from m50-133.163.com ([123.125.50.133]:53501 "EHLO m50-133.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbcLDGI1 (ORCPT ); Sun, 4 Dec 2016 01:08:27 -0500 From: Pan Bian To: Borislav Petkov , Mauro Carvalho Chehab , linux-edac@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH 1/1] edac: fix improper return value Date: Sun, 4 Dec 2016 14:07:18 +0800 Message-Id: <1480831638-5361-1-git-send-email-bianpan201604@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: DdGowABnMJiVskNYuWmVIw--.62761S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Xw13CF17Xry8CF1DZFy7Wrg_yoWfZFc_ur W8Wr4xWrsYyrZ5Ka1xCFWayrykt3WUXwn5KFn3K34a9ry7ur1fZFs8uFZ8Xr47Xws7uFyj ganY9rySyr4DWjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUYgmitUUUUU== X-Originating-IP: [114.243.30.33] X-CM-SenderInfo: held01tdqsiiqwquqiywtou0bp/1tbiURc2+1WBA7HtlwAAsX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian When the call to zalloc_cpumask_var() fails, returning "false" seems improper. The real value of macro "false" is 0, and 0 means no error. This patch fixes the bug, returning "-ENOMEM". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071 Signed-off-by: Pan Bian --- drivers/edac/amd64_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index ee181c5..72a2c75 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -2539,7 +2539,7 @@ static int toggle_ecc_err_reporting(struct ecc_settings *s, u16 nid, bool on) if (!zalloc_cpumask_var(&cmask, GFP_KERNEL)) { amd64_warn("%s: error allocating mask\n", __func__); - return false; + return -ENOMEM; } get_cpus_on_this_dct_cpumask(cmask, nid); -- 1.9.1