From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752800AbcLDGQO (ORCPT ); Sun, 4 Dec 2016 01:16:14 -0500 Received: from m50-132.163.com ([123.125.50.132]:33352 "EHLO m50-132.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752585AbcLDGQN (ORCPT ); Sun, 4 Dec 2016 01:16:13 -0500 From: Pan Bian To: Artem Bityutskiy , Richard Weinberger , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH 1/1] mtd: ubi: fix improper return value Date: Sun, 4 Dec 2016 14:12:10 +0800 Message-Id: <1480831930-5449-1-git-send-email-bianpan201604@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: DNGowAD3ze25s0NYTDmzIQ--.63090S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7XryDWFy3try3Jw4rWF1ftFb_yoWfWFbE9r yxXrsagrsYkF48Kw1SkFW3Wry29w4F9Fna9F1ftwsxAF47CayYvF92gr98Xr4kZw4IyFyD WayvqF12yr17JjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUYByIUUUUUU== X-Originating-IP: [114.243.30.33] X-CM-SenderInfo: held01tdqsiiqwquqiywtou0bp/1tbiJx02+1XlhMM7PgAAsF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian When __vmalloc() returns a NULL pointer, the region is not checked, and we cannot make sure that only 0xFF bytes are present at offset. Thus, returning 0 seems improper. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189081 Signed-off-by: Pan Bian --- drivers/mtd/ubi/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c index b6fb8f9..b54fe05 100644 --- a/drivers/mtd/ubi/io.c +++ b/drivers/mtd/ubi/io.c @@ -1413,7 +1413,7 @@ int ubi_self_check_all_ff(struct ubi_device *ubi, int pnum, int offset, int len) buf = __vmalloc(len, GFP_NOFS, PAGE_KERNEL); if (!buf) { ubi_err(ubi, "cannot allocate memory to check for 0xFFs"); - return 0; + return -ENOMEM; } err = mtd_read(ubi->mtd, addr, len, &read, buf); -- 1.9.1