From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932453AbcLMEkT (ORCPT ); Mon, 12 Dec 2016 23:40:19 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:36095 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932366AbcLMEkO (ORCPT ); Mon, 12 Dec 2016 23:40:14 -0500 X-ME-Sender: X-Sasl-enc: V+YAXNst3RNQFw2c3WxOzu/92Z1upsSwbG2k6bp9iDbI 1481604007 Message-ID: <1481604000.3112.30.camel@aj.id.au> Subject: Re: [PATCH v3 4/6] mfd: dt: Add bindings for the Aspeed LPC Host Controller (LHC) From: Andrew Jeffery To: Rob Herring Cc: Lee Jones , Mark Rutland , Linus Walleij , Corey Minyard , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Joel Stanley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 13 Dec 2016 15:10:00 +1030 In-Reply-To: <20161212153018.lfkicwknikfbzdlf@rob-hp-laptop> References: <20161206025321.1792-1-andrew@aj.id.au> <20161206025321.1792-5-andrew@aj.id.au> <20161212153018.lfkicwknikfbzdlf@rob-hp-laptop> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-qq3Tfj7JwU7kAgTTQ9z1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-qq3Tfj7JwU7kAgTTQ9z1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-12-12 at 09:30 -0600, Rob Herring wrote: > On Tue, Dec 06, 2016 at 01:53:19PM +1100, Andrew Jeffery wrote: > > The LPC bus pinmux configuration on fifth generation Aspeed SoCs depend= s > > on bits in both the System Control Unit and the LPC Host Controller. > >=20 > > The Aspeed LPC Host Controller is described as a child node of the > > LPC host-range syscon device for arbitration of access by the host > > controller and pinmux drivers. > >=20 > > > > Signed-off-by: Andrew Jeffery > > --- > > =C2=A0.../devicetree/bindings/mfd/aspeed-lpc.txt=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 22 ++++++++++++++++++++++ > > =C2=A01 file changed, 22 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Doc= umentation/devicetree/bindings/mfd/aspeed-lpc.txt > > index a97131aba446..9de318ef72da 100644 > > --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > > +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > > > > @@ -109,3 +109,25 @@ lpc: lpc@1e789000 { > > > > =C2=A0 }; > > =C2=A0}; > > =C2=A0 > > +Host Node Children > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + > > +LPC Host Controller > > +------------------- > > + > > +The Aspeed LPC Host Controller configures the Low Pin Count (LPC) bus = behaviour > > +between the host and the baseboard management controller. The register= s exist > > +in the "host" portion of the Aspeed LPC controller, which must be the = parent of > > +the LPC host controller node. > > + > > +Required properties: > > > > +- compatible: "aspeed,ast2500-lhc"; > > > > +- reg: contains offset/length value of the LHC memory > > + region. >=20 > How many regions? Looks like 2. Yes, two. The first region is registers configuring various LPC host controller properties. The second region is for configuring the LPC serial IRQ trigger modes. Would you like me to say as much in the patch? It's not a completely clear split of functionality as other serial IRQ properties are also described in the first region. Maybe describing the datasheet's register names for the regions (LHCR[0-8] for the first, LHCR[A-B] for the second) would help? Cheers, Andrew >=20 > > + > > +Example: > > + > > > > +lhc: lhc@20 { > > > > + compatible =3D "aspeed,ast2500-lhc"; > > > > + reg =3D <0x20 0x24 0x48 0x8>; > > +}; > > --=C2=A0 > > 2.9.3 > >=20 --=-qq3Tfj7JwU7kAgTTQ9z1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIcBAABCgAGBQJYT3ugAAoJEJ0dnzgO5LT53UcQAKPkMw1FYSnd5ExxSfher5i0 Stfou/u6b5IcMwQDxJPXY3iNVxzFHfpvrrxx3fIGELJy45ZtgOq83J1V1+aIOWO/ 2MmEmuBfU9Hc7AEaQeIM5kkVvXZRQJGr8RT3u7tnn2af9YbWRpjbwIvhXkZ5rVwf NM+qL/yBdDl15uplAerPXgutbcBJgQRNtmcsxOhok0Y2fABcNcwx75dMC3ss8U7E WURYhfCI2tF9tkebi8/4jK0TqtQ94lBxqStNBB8uTDs2dk57IN7PEBrMU1su+Y1M UIbIcWJf302+3a2ktHW6+k8zEdBM4LyA8r3pbjbK2GzVTQ6aGx90h2iMpk/+cwM9 wO0Smtm7obWXwr2bd1x8kRR3S/5fAkQskkIv3b+f3Bsk13t+N08e62FlQ/bDDMek rOrDM0oqTx3JSvPDZXEc/KXmYgltIkKDfFBzNlzlWPsfIv6ZRqsYiS7uaOTe0p0L f03Md2cjgYpcahZUG48XR3l+ojfoB9qC1ZoIBjXmezF0SCtsbnw8TeESiabP2rot xP4B9Z2IN2W6lX0m+19vZc7hSQew4fo1omPEJ5RrzMTS+F/yDZZGPeYsNd3NXjxi ZDzQlmwGWddMD62Klvr7pp8+1moapZyBcwVZrqFF27jL7+r9iM1ow9mzutv69NzS DLbGLk9cZ2otX7fRtDp8 =2X6s -----END PGP SIGNATURE----- --=-qq3Tfj7JwU7kAgTTQ9z1--