From: Vadim Pasternak <vadimp@mellanox.com>
To: dvhart@infradead.org
Cc: platform-driver-x86@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, jiri@resnulli.us,
andriy.shevchenko@linux.intel.com,
Vadim Pasternak <vadimp@mellanox.com>
Subject: [patch v1 0/1] platform/x86: mlx-platform: mlxcpld-hotplug driver notes
Date: Wed, 14 Dec 2016 12:05:14 +0000 [thread overview]
Message-ID: <1481717115-60362-1-git-send-email-vadimp@mellanox.com> (raw)
This patch contains the non-functional fixes, pointed out by Andy.
I was waiting with sending the patch until the patch which moves
mlx-platform driver from arch/x86/platform/mellanox to
drivers/platform/x86 folder is accepted.
Now after the below patches are committed to the testing branch:
platform/x86: mlx-platform: Move module from arch/x86 is committed.
platform/x86: mlx-platform: Add mlxcpld-hotplug driver registration
a15e902e1a00715edc09bd1862e27f84f0a86fda
4065133df054abf4f7f41bdc15af0c7a1fd66d71
6b45a3612118878ab4f221ce49997e67687ef588
I'd like to apply the comments pointed out by Andy:
- Make names of hotplug devices shorter;
- Change register offset assignment to defines;
- Add defines for the all event masks;
- Use PLATFORM_DEVID_NONE instead of -1;
Vadim Pasternak (1):
platform/x86: mlx-platform: mlxcpld-hotplug driver style fixes
drivers/platform/x86/mlx-platform.c | 84 ++++++++++++++++++++++---------------
1 file changed, 50 insertions(+), 34 deletions(-)
--
2.1.4
next reply other threads:[~2016-12-14 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 12:05 Vadim Pasternak [this message]
2016-12-14 12:05 ` [patch v1 1/1] platform/x86: mlx-platform: mlxcpld-hotplug driver style fixes Vadim Pasternak
2016-12-27 11:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481717115-60362-1-git-send-email-vadimp@mellanox.com \
--to=vadimp@mellanox.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®