From: Stefano Stabellini <sstabellini@kernel.org>
To: v9fs-developer@lists.sourceforge.net
Cc: sstabellini@kernel.org, ericvh@gmail.com, rminnich@sandia.gov,
lucho@ionkov.net, linux-kernel@vger.kernel.org
Subject: [PATCH v2 7/7] 9p: handle large aio write requests
Date: Thu, 15 Dec 2016 14:13:54 -0800 [thread overview]
Message-ID: <1481840034-2113-7-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1481840034-2113-1-git-send-email-sstabellini@kernel.org>
When an async write larger then msize-P9_IOHDRSZ is issued, do not limit
the write size to msize-P9_IOHDRSZ. Instead, keep sending write requests
from the completion function, until the original write is completed.
Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
---
Is there a better way to reconstruct the from iov_iter?
---
net/9p/client.c | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 74 insertions(+), 3 deletions(-)
diff --git a/net/9p/client.c b/net/9p/client.c
index 8d2f8f7..89b2fee 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -1806,7 +1806,6 @@ int p9_client_unlinkat(struct p9_fid *dfid, const char *name, int flags)
if (count > req->rsize)
count = req->rsize;
- err = count;
file = req->kiocb->ki_filp;
inode = file_inode(file);
pg_start = req->kiocb->ki_pos >> PAGE_SHIFT;
@@ -1821,9 +1820,73 @@ int p9_client_unlinkat(struct p9_fid *dfid, const char *name, int flags)
inode_add_bytes(inode, req->kiocb->ki_pos - i_size);
i_size_write(inode, req->kiocb->ki_pos);
}
+
+ req->completed += count;
+ req->file_offset += count;
+ req->page_offset += count;
+ err = req->completed;
+ if (req->tot_size - req->completed > 0 && count == req->rsize) {
+ struct p9_req_t *req2;
+ struct iov_iter from;
+ struct kvec v[(clnt->msize - P9_IOHDRSZ + PAGE_SIZE) / PAGE_SIZE];
+ u64 rsize = req->tot_size - req->completed;
+ u64 offset = req->page_offset % PAGE_SIZE;
+ u32 total = 0, n = 0;
+ int i, j;
+
+ if (rsize > req->fid->iounit)
+ rsize = req->fid->iounit;
+ if (rsize > clnt->msize-P9_IOHDRSZ)
+ rsize = clnt->msize - P9_IOHDRSZ;
+
+ for (j = 0, i = req->page_offset / PAGE_SIZE;
+ total < rsize; i++, j++) {
+ v[j].iov_base = kmap(req->pagevec[i]) + offset;
+ n = PAGE_SIZE - offset;
+ if (n > rsize - total)
+ n = rsize - total;
+ else
+ offset = 0;
+ v[j].iov_len = n;
+ total += n;
+ }
+ iov_iter_kvec(&from, WRITE|ITER_KVEC, v, i, rsize);
+
+ req2 = p9_client_get_req(clnt, P9_TWRITE, "dqV", req->fid->fid,
+ req->file_offset, rsize, &from);
+ if (IS_ERR(req2)) {
+ err = PTR_ERR(req2);
+ goto out;
+ }
+ req2->fid = req->fid;
+ req2->rsize = rsize;
+ req2->completed = req->completed;
+ req2->tot_size = req->tot_size;
+ req2->file_offset = req->file_offset;
+ req2->page_offset = req->page_offset;
+ req2->kiocb = req->kiocb;
+ req2->pagevec = req->pagevec;
+ INIT_WORK(&req2->work, p9_client_write_complete);
+
+ err = clnt->trans_mod->request(clnt, req2);
+
+ for (i -= j; j > 0; i++, j--)
+ kunmap(req2->pagevec[i]);
+
+ if (err < 0) {
+ clnt->status = Disconnected;
+ p9_free_req(clnt, req2);
+ goto out;
+ }
+ goto out2;
+ }
+
out:
req->kiocb->ki_complete(req->kiocb, err, 0);
+ release_pages(req->pagevec, (req->tot_size + PAGE_SIZE - 1) / PAGE_SIZE, false);
+ kvfree(req->pagevec);
+out2:
p9_free_req(clnt, req);
}
@@ -1833,7 +1896,7 @@ int p9_client_unlinkat(struct p9_fid *dfid, const char *name, int flags)
{
struct p9_client *clnt = fid->clnt;
struct p9_req_t *req;
- int total = 0;
+ int total = 0, i;
*err = 0;
p9_debug(P9_DEBUG_9P, ">>> TWRITE fid %d offset %llu count %zd\n",
@@ -1868,14 +1931,22 @@ int p9_client_unlinkat(struct p9_fid *dfid, const char *name, int flags)
}
req->fid = fid;
req->rsize = rsize;
- req->tot_size = count;
req->file_offset = offset;
req->kiocb = iocb;
INIT_WORK(&req->work, p9_client_write_complete);
+ req->tot_size = iov_iter_get_pages_alloc(from, &req->pagevec,
+ (size_t)count, &req->page_offset);
+ for (i = 0; i < req->tot_size; i += PAGE_SIZE)
+ page_cache_get_speculative(req->pagevec[i/PAGE_SIZE]);
+
*err = clnt->trans_mod->request(clnt, req);
if (*err < 0) {
clnt->status = Disconnected;
+ release_pages(req->pagevec,
+ (req->tot_size + PAGE_SIZE - 1) / PAGE_SIZE,
+ true);
+ kvfree(req->pagevec);
p9_free_req(clnt, req);
break;
}
--
1.9.1
next prev parent reply other threads:[~2016-12-15 22:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 22:12 [PATCH v2 0/7] async requests support for 9pfs Stefano Stabellini
2016-12-15 22:13 ` [PATCH v2 1/7] 9p: add iocb parameter to p9_client_read and p9_client_write Stefano Stabellini
2016-12-15 22:13 ` [PATCH v2 2/7] 9p: store req details and workqueue in struct p9_req_t Stefano Stabellini
2016-12-15 22:13 ` [PATCH v2 3/7] 9p: introduce p9_client_get_req Stefano Stabellini
2016-12-15 22:13 ` [PATCH v2 4/7] 9p: introduce async read requests Stefano Stabellini
2016-12-15 22:13 ` [PATCH v2 5/7] 9p: introduce async write requests Stefano Stabellini
2016-12-15 22:13 ` [PATCH v2 6/7] 9p: handle large aio read requests Stefano Stabellini
2016-12-15 22:13 ` Stefano Stabellini [this message]
2017-01-03 23:37 ` [PATCH v2 0/7] async requests support for 9pfs Stefano Stabellini
2017-02-17 1:00 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481840034-2113-7-git-send-email-sstabellini@kernel.org \
--to=sstabellini@kernel.org \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome