From: Joe Perches <joe@perches.com>
To: Tabrez khan <khan.tabrez21@gmail.com>,
oleg.drokin@intel.com, jsimmons@infradead.org,
andreas.dilger@intel.com
Cc: gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging : lustre : Remove braces from single-line body.
Date: Fri, 16 Dec 2016 10:43:24 -0800 [thread overview]
Message-ID: <1481913804.29291.92.camel@perches.com> (raw)
In-Reply-To: <1481911175-19592-1-git-send-email-khan.tabrez21@gmail.com>
On Fri, 2016-12-16 at 23:29 +0530, Tabrez khan wrote:
> Remove unnecessary braces {} from single line if statement.
> This warning is found using checkpatch.pl.
[]
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/import.c b/drivers/staging/lustre/lustre/ptlrpc/import.c
[]
> @@ -1134,9 +1134,9 @@ static int ptlrpc_connect_interpret(const struct lu_env *env,
> }
>
> /* Sanity checks for a reconnected import. */
> - if (!(imp->imp_replayable) != !(msg_flags & MSG_CONNECT_REPLAYABLE)) {
> + if (!(imp->imp_replayable) != !(msg_flags & MSG_CONNECT_REPLAYABLE))
> CERROR("imp_replayable flag does not match server after reconnect. We should LBUG right here.\n");
> - }
> +
There are one too many blank lines now.
And that's an awful lot of !s.
Generically, it might make simpler reading code to
cast to bool instead of using !.
Most code uses !! to make sure whatever value is
either 0 or 1 without changing the logic/polarity.
next prev parent reply other threads:[~2016-12-16 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 17:59 Tabrez khan
2016-12-16 18:43 ` Joe Perches [this message]
2016-12-16 18:53 ` Dan Carpenter
2016-12-16 19:19 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2016-12-29 20:02 [PATCH] staging:lustre:remove " Tabrez khan
2016-12-28 14:10 [PATCH] staging : lustre : Remove " Tabrez khan
2017-01-03 14:15 ` Greg KH
2016-12-16 14:29 Tabrez khan
2016-12-16 16:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481913804.29291.92.camel@perches.com \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=khan.tabrez21@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome