From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68869C63697 for ; Mon, 23 Nov 2020 17:33:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1433A2072C for ; Mon, 23 Nov 2020 17:33:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390363AbgKWRdd (ORCPT ); Mon, 23 Nov 2020 12:33:33 -0500 Received: from smtprelay0151.hostedemail.com ([216.40.44.151]:41386 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730356AbgKWRdc (ORCPT ); Mon, 23 Nov 2020 12:33:32 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id DE947837F24F; Mon, 23 Nov 2020 17:33:31 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: woman80_51130f927367 X-Filterd-Recvd-Size: 1792 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Mon, 23 Nov 2020 17:33:30 +0000 (UTC) Message-ID: <148208ef84344069a6c95d3f686a86ca1199be90.camel@perches.com> Subject: Re: [PATCH v4] checkpatch: add fix and improve warning msg for Non-standard signature From: Joe Perches To: Aditya Srivastava , lukas.bulwahn@gmail.com Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Date: Mon, 23 Nov 2020 09:33:29 -0800 In-Reply-To: <20201123172430.12854-1-yashsri421@gmail.com> References: <20201123172430.12854-1-yashsri421@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-11-23 at 22:54 +0530, Aditya Srivastava wrote: > Currently, checkpatch.pl warns for BAD_SIGN_OFF on non-standard signature > styles. I think this proposed change is unnecessary. > This warning occurs because of incorrect use of signature tags, > e.g. an evaluation on v4.13..v5.8 showed the use of following incorrect > signature tags, which may seem correct, but are not standard: Standards are useful, but standards are not constraints. > 1) Requested-by (count: 48) => Suggested-by > Rationale: In an open-source project, there are no 'requests', just > 'suggestions' to convince a maintainer to accept your patch There's nothing really wrong with some non-standard signatures. And I think leaving humor like brown-paper-bag-by: is useful. Just telling people that they are using a non-standard signature I think is enough.